-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS-1209][DOCS-1204] Document full-screen panel view, various panel sharing options, customizing number of panels per section #1087
base: main
Are you sure you want to change the base?
Conversation
Images automagically compressed by Calibre's image-actions ✨ Compression reduced images by 35.5%, saving 3.61 KB.
439 images did not require optimisation. |
Deploying docs with
|
Latest commit: |
1642fbc
|
Status: | ✅ Deploy successful! |
Preview URL: | https://6e818f5b.docodile.pages.dev |
Branch Preview URL: | https://docs-1209.docodile.pages.dev |
Images automagically compressed by Calibre's image-actions ✨ Compression reduced images by 35.5%, saving 3.61 KB.
439 images did not require optimisation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm with minor suggestion. not sure if you need product/vis approval too?
Who would you suggest or where should I ask for a reviewer? |
I'm not really sure what the expected process is for docs changes either. Is an engineer the right person to approve? Does a product manager need to sign off too (in this case that would be Tristan)? Or the eng manager? @ktmathews89 I'd love to chat about this, maybe at the next team sync |
Great question... I will add this topic to our retro doc. After we decide we can let docs team know in the DOCs ticket who should be approving. |
Let's move internal process discussions elsewhere. :) I'll start a thread. |
|
||
If multiple panels have the same name, this is the URL for the first panel with the name. In this case, find the URL by [viewing the panel in full-screen mode]({{< relref "#view-and-share-a-panel-in-full-screen-mode" >}}). | ||
|
||
### Share a panel with a direct link that anyone can access |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like this and the following section are basically the same thing, the difference is whether it's a public link or not. Maybe they could be consolidated?
1. Click **Share panel in report**. | ||
1. In the **Share** tab, change **Only those who are invited have access** to **Anyone with the link cah view**, then choose **Share on Twitter**, **Share on Reddit**, **Share on LinkedIn**, or **Copy embed link**. | ||
|
||
### Determine a panel's full-screen URL programmatically |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think is hanging...you covered in a subsection above I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe I'm misunderstanding. I think it is useful information we should documented, I just thought it was documented in the section "Compose a panel's full-screen URL programmatically" above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I think I finally understood, and have tried to address this in the latest commit.
- Remove stray H3 - Combine the share-by-email and share-by-direct-link sections
DOCS-1209 Document full-screen panel view and various panel sharing options
DOCS-1204 Customize the number of panels in a section
Previews:
https://docs-1209.docodile.pages.dev/guides/app/features/panels/#share-panels
https://docs-1209.docodile.pages.dev/guides/app/features/panels/#manage-a-sections-visible-panels