Try to fix Lychee github action error #1034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdlinville
force-pushed
the
try_fix_lychee
branch
from
6ae9346 to
93e07a7
Compare
Deploying docs with
|
| Latest commit: |
7b5b014
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://bd4339a4.docodile.pages.dev |
| Branch Preview URL: | https://try-fix-lychee.docodile.pages.dev |
mdlinville
force-pushed
the
try_fix_lychee
branch
4 times, most recently
from
f896b96 to
ce5243b
Compare
johndmulhausen
previously requested changes
Jan 28, 2025
There was a problem hiding this comment.
The reason I think we should accept 429 responses is to clean up GitHub's rate limiting errors from the reports. We pass in a token and that should be giving us 1000 requests and hour but with the number of commits we push and number of links we have it seems to be hitting the ceiling.
In addition, I think we should convert this to a cron job that we run, say, monthly? It's going to file github issues when there's an issue (and it already has filed several from your tests).
mdlinville
force-pushed
the
try_fix_lychee
branch
from
e697e7e to
f03d8cc
Compare
mdlinville
dismissed
johndmulhausen’s stale review
Discussed offline, we need to merge this so we can see if the crontab works tomorrow!
mdlinville
commented
Jan 31, 2025
johndmulhausen
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the Lychee GitHub action so it doesn't fail on each PR
mainusing a cron schedule, for 12:01 AM on the 1st of each month