Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update references to RLN contract address #3287

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stubbsta
Copy link

Description

This PR is part of #3190, which requires that the RLN contract address is updated to the new contract address.
This PR needs to be merged with all other PRs related to #3190 as well as #3272

Changes

Contract address changed from 0xCB33Aa5B38d79E3D9Fa8B10afF38AA201399a7e3 to [0xB9cd878C90E49F797B4431fBF4fb333108CB90e6](https://sepolia.lineascan.build/address/0xB9cd878C90E49F797B4431fBF4fb333108CB90e6) in the following files:

How to test

This cannot be tested at this time.
The RLN tests in nwaku first need to be updated as well as the contract registration tools.

Issue closes

Part of closing #3190

Copy link

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:3287

Built from a6f7e6b

@stubbsta stubbsta changed the title Update references to RLN contract address chore: Update references to RLN contract address Feb 10, 2025
Copy link
Member

@richard-ramos richard-ramos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good.
I have a doubt: should we wait to merge this PR until the changes in the code required to work with this new contract are implemented?

@stubbsta
Copy link
Author

I think we should wait, I plan to make another PR for the updated registration tool and any other related functionality.
This PR can then be merged at the same time as that one.

Copy link
Contributor

@jm-clius jm-clius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. LGTM, but since this change will break functionality until we have updated the code to use the new contract, this shouldn't be merged for now. Perhaps you can convert this to a Draft PR, which indicates work for which feedback can be given but that shouldn't be merged?

@stubbsta stubbsta marked this pull request as draft February 11, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants