chore: better proof handling in REST #3286
Merged
+37
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can find the image built from this PR at Built from b9fcaef |
Ivansete-status
requested review from
darshankabariya,
gabrielmer and
NagyZoltanPeter
NagyZoltanPeter
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Investigating another REST lightpush issue reported by @AlbertoSoutullo in the
v0.35.0-rc.1I noticed that we weren't supporting the example shown in https://waku-org.github.io/waku-rest-api/#post-/lightpush/v1/messageThis PR aims to support that example.
It is exptected that the
waku-interop-testsare failing. The followingwaku-interop-testsPR was submitted to fix that: waku-org/waku-interop-tests#105 and this issue shouldn't happen in upcoming PRs.Issue