chore: dbconn truncate possible too long error messages #3283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can find the image built from this PR at Built from c5a3acf |
Ivansete-status
requested review from
NagyZoltanPeter,
darshankabariya and
gabrielmer
jakubgs
reviewed
Feb 8, 2025
| @@ -300,18 +302,19 @@ proc dbConnQueryPrepared*( | |||
| error "error in dbConnQueryPrepared", error = $error | |||
| return err("error in dbConnQueryPrepared calling sendQuery: " & $error) | |||
|
|
|||
| let stmtNameSummary = stmtName[0 ..< min(stmtName.len, 128)] | |||
There was a problem hiding this comment.
This is incorrect. The issue isn't length but cardinality of labels. We need another fix for these metrics.
No metrics should set values for labels that are unbound.
There was a problem hiding this comment.
Please read: https://prometheus.io/docs/practices/naming/#labels
|
Thanks for clarifying @jakubgs ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
libpq sometimes gives extremly long error messages. This PRs limits that
Issue
closes #3282