Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "chore: waku_archive add protection against queries longer than 24h" #3278

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

Ivansete-status
Copy link
Collaborator

@Ivansete-status Ivansete-status commented Feb 5, 2025

Reverts #3256

See the detail of the decision in: #3170 (comment)

Copy link

github-actions bot commented Feb 5, 2025

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "Revert "chore: waku_archive add protection against queries longer than 24h"". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:

  • chore
  • docs
  • feat
  • fix
  • refactor
  • style
  • test

@Ivansete-status Ivansete-status marked this pull request as ready for review February 5, 2025 18:54
Copy link

github-actions bot commented Feb 5, 2025

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:3278

Built from 06dd791

Copy link
Contributor

@gabrielmer gabrielmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Contributor

@NagyZoltanPeter NagyZoltanPeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ok to revert it, but why not just allow "infinite" time range without removing the validator?

@Ivansete-status
Copy link
Collaborator Author

It's ok to revert it, but why not just allow "infinite" time range without removing the validator?

ah yes good point! I think the answer is that "revert" was one button click ;P

@Ivansete-status Ivansete-status merged commit d391357 into master Feb 6, 2025
6 of 8 checks passed
@Ivansete-status Ivansete-status deleted the revert-3256-cap-max-time-range-query branch February 6, 2025 16:44
Ivansete-status added a commit that referenced this pull request Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants