-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Relase v0.35 #3269
base: master
Are you sure you want to change the base?
chore: Relase v0.35 #3269
Conversation
You can find the image built from this PR at
Built from 8de21fb |
Thanks so much! I think we should include a note with the configuration changes since the last release, for example the deprecation of We should also update accordingly https://docs.waku.org/guides/nwaku/config-options but that's something separate I also liked when we added a "Release highlights" section at the beginning so we have a TLDR for it - it's a nice to have but not strictly necessary though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments ahead.
|
||
### Changes | ||
|
||
- filter remove all subscription from a peer that is leaving ([#3267](https://github.com/waku-org/nwaku/issues/3267)) ([46747fd49](https://github.com/waku-org/nwaku/commit/46747fd49)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I remember correctly, this description is not true anymore with the final solution. Maybe to rephrase this sentence.
CHANGELOG.md
Outdated
- send msg hash as string on libwaku message event ([#3234](https://github.com/waku-org/nwaku/issues/3234)) ([9c209b4c3](https://github.com/waku-org/nwaku/commit/9c209b4c3)) | ||
- compile with skipParentCfg ([#3262](https://github.com/waku-org/nwaku/issues/3262)) ([aaf3c0070](https://github.com/waku-org/nwaku/commit/aaf3c0070)) | ||
- bump dependencies for v0.35 ([#3255](https://github.com/waku-org/nwaku/issues/3255)) ([f8a233381](https://github.com/waku-org/nwaku/commit/f8a233381)) | ||
- waku_archive add protection against queries longer than 24h ([#3256](https://github.com/waku-org/nwaku/issues/3256)) ([a4d71718a](https://github.com/waku-org/nwaku/commit/a4d71718a)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't it worth a highlighted notice, as it may break some client implementations?
- waku_archive add protection against queries longer than 24h ([#3256](https://github.com/waku-org/nwaku/issues/3256)) ([a4d71718a](https://github.com/waku-org/nwaku/commit/a4d71718a)) | ||
- separate heaptrack from debug build ([#3249](https://github.com/waku-org/nwaku/issues/3249)) ([81f24cc25](https://github.com/waku-org/nwaku/commit/81f24cc25)) | ||
- adding debug flag to makefile ([#3248](https://github.com/waku-org/nwaku/issues/3248)) ([dfd06fa72](https://github.com/waku-org/nwaku/commit/dfd06fa72)) | ||
- capping mechanism for relay and service connections ([#3184](https://github.com/waku-org/nwaku/issues/3184)) ([2942782f9](https://github.com/waku-org/nwaku/commit/2942782f9)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is also a noticeable change in configuration and in expected capabilities.
cc: @darshankabariya
CHANGELOG.md
Outdated
- Partial version bumps for v0.34.0-rc.1 ([#3172](https://github.com/waku-org/nwaku/issues/3172)) ([8368ff006](https://github.com/waku-org/nwaku/commit/8368ff006)) | ||
- libwaku better error handling and better waku thread destroy handling ([#3167](https://github.com/waku-org/nwaku/issues/3167)) ([294dd03c4](https://github.com/waku-org/nwaku/commit/294dd03c4)) | ||
- libwaku allow several multiaddresses for a single peer in store queries ([#3171](https://github.com/waku-org/nwaku/issues/3171)) ([3cb8ebdd8](https://github.com/waku-org/nwaku/commit/3cb8ebdd8)) | ||
- remove protected-topic cli flg ([#3160](https://github.com/waku-org/nwaku/issues/3160)) ([8fde70937](https://github.com/waku-org/nwaku/commit/8fde70937)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has to be mentioned highlighted I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this particular change was introduced in the previous version. I will remove it.
- waku store sync 2.0 config & setup ([#3217](https://github.com/waku-org/nwaku/issues/3217)) ([7f64dc03a](https://github.com/waku-org/nwaku/commit/7f64dc03a)) | ||
- waku store sync 2.0 protocols & tests ([#3216](https://github.com/waku-org/nwaku/issues/3216)) ([6ee494d90](https://github.com/waku-org/nwaku/commit/6ee494d90)) | ||
- waku store sync 2.0 storage & tests ([#3215](https://github.com/waku-org/nwaku/issues/3215)) ([54a7a6875](https://github.com/waku-org/nwaku/commit/54a7a6875)) | ||
- waku store sync 2.0 common types & codec ([#3213](https://github.com/waku-org/nwaku/issues/3213)) ([29fda2dab](https://github.com/waku-org/nwaku/commit/29fda2dab)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New protocol worth some words under notes paragraph. cc: @SionoiS
6e220bc
to
54b68e7
Compare
#3281) Better control when the remote peer closes the WakuFilterPushCodec stream. For example, go-waku closes the stream for every received message. On the other hand, js-waku keeps the stream opened. Therefore, we support both scenarios.
Co-authored-by: Simon-Pierre Vivier <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazingg, thanks so much! 🔥
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
I'm not 100% sure how the mentioned changes over filter subscription management changes are overlapping each other thus one makes obsolete the other...
Description
Release v0.35.0
Issue
closes #3251