feat(sds): add message channel with buffers and send/receive logic #2261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adklempner
force-pushed
the
feat/sds-participant-state
branch
from
1752c2c to
e78c0a8
Compare
size-limit report 📦
|
adklempner
force-pushed
the
feat/sds-participant-state
branch
2 times, most recently
from
ba4aa1e to
935e2d1
Compare
adklempner
changed the title
This commit creates the class for an SDS message channel, including buffers for outgoing and incoming messages. Adds logic for sending messages, receiving messages, delivering messages, and reviewing acknowledgement status of messages. Also adds byte serialization for bloom filters.
adklempner
force-pushed
the
feat/sds-participant-state
branch
from
935e2d1 to
5f6ca97
Compare
weboko
reviewed
Feb 14, 2025
| } | ||
|
|
||
| // TODO: this should be determined based on the bloom filter parameters and number of hashes | ||
| private getAcknowledgementCount(): number { |
There was a problem hiding this comment.
nit: private should be after public
weboko
reviewed
Feb 14, 2025
|
|
||
| const DEFAULT_CAUSAL_HISTORY_SIZE = 2; | ||
|
|
||
| export class MessageChannel { |
There was a problem hiding this comment.
is this class intended to be used by consumers? if so, can you generate js doc comments for public methods?
There was a problem hiding this comment.
It's likely there will be a ParticipantState class that holds one or more of these, but either way I will add some docs to the public methods
weboko
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem / Description
We need to implement the library for SDS in browser based on the specification.
Solution
This commit implements and adds unit tests for everything in the specification up to and including
Review ACK Status: https://rfc.vac.dev/vac/raw/sds/#review-ack-statusNotes
Checklist