feat(sds): migrate bloomfilter to bigint and import hashn function from nim #2253
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem / Description
Bloom filter implementation for SDS needs to match behavior of nim implementation. Specifically, the hashing algorithm and insert/lookup functions should result in the same bit vectors given the same bloom filter parameters and inputs.
Solution
bigint
to store sufficient bits in bloom filter.int
when compiled usingNim Compiler Version 2.2.0 [MacOSX: arm64]
nim js -d:release --threads:off --opt:speed --jsbigint64:off -d:nimStringHash2 src/nim_hashn.nim
Notes
Checklist