chore: upgrade nwaku to 0.34.0 and update tests suite for compatibility #2170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
danisharora099
force-pushed
the
chore/upgrade-nwaku
branch
from
19b817a to
36952bd
Compare
danisharora099
changed the title
danisharora099
changed the title
danisharora099
force-pushed
the
chore/upgrade-nwaku
branch
3 times, most recently
from
e27033a to
c48d1b8
Compare
danisharora099
changed the title
|
Is it ready for review? Both test steps has failed :( |
All of the tests seem to pass, but the CI runner doesn't seem to exit out of the process |
danisharora099
force-pushed
the
chore/upgrade-nwaku
branch
9 times, most recently
from
b78448b to
4edbc06
Compare
danisharora099
force-pushed
the
chore/upgrade-nwaku
branch
4 times, most recently
from
20c8e4f to
5d209e9
Compare
adklempner
approved these changes
Feb 4, 2025
weboko
reviewed
Feb 4, 2025
| await sendMessagesAutosharding(nwaku, totalMsgs, customContentTopic1); | ||
| await sendMessagesAutosharding(nwaku, totalMsgs, customContentTopic2); | ||
| for (let i = 0; i < totalMsgs; i++) { | ||
| await serviceNodes.sendRelayMessage( |
There was a problem hiding this comment.
previous method seems more convenient that that
There was a problem hiding this comment.
true, something buggy with the autosharding API, confirming -- similar reason for #2170 (comment)
weboko
reviewed
Feb 4, 2025
| @@ -236,54 +255,6 @@ describe("Waku Store (Autosharding), custom pubsub topic", function () { | |||
| }); | |||
| expect(result2).to.not.eq(-1); | |||
| }); | |||
|
|
|||
| it("Generator, 2 nwaku nodes each with different pubsubtopics", async function () { | |||
There was a problem hiding this comment.
why removed? it seems like a viable test case
weboko
requested changes
Feb 4, 2025
weboko
approved these changes
Feb 10, 2025
|
looks good, node tests fail tho |
…f just one) - nwaku now expects >=1 nodes at least connected
danisharora099
force-pushed
the
chore/upgrade-nwaku
branch
3 times, most recently
from
01f61c5 to
98179ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request upgrades the nwaku dependency to version
0.34.0and includes various improvements and fixes in the test suite to accommodate this upgrade. Key changes include:Notes
nwakuto0.34.0and check interop tests #2176Contribution checklist:
!in title if breaks public API;