Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add a test that uses ping to check filter subscription #1656

Merged
merged 3 commits into from
Oct 13, 2023

Conversation

danisharora099
Copy link
Collaborator

This PR adds a test for Filter that depicts how Filter ping should be used to check for active Filter subscriptions with service nodes.

This is in reference to #914 (comment) & waku-org/docs.waku.org#104 (comment)

@danisharora099 danisharora099 requested a review from a team as a code owner October 12, 2023 07:52
@danisharora099 danisharora099 changed the title add a test that uses ping to check filter subscription chore: add a test that uses ping to check filter subscription Oct 12, 2023
@github-actions
Copy link

github-actions bot commented Oct 12, 2023

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Waku core 83.28 KB (0%) 1.7 s (0%) 271 ms (-7.37% 🔽) 2 s
Waku Simple Light Node 263.25 KB (0%) 5.3 s (0%) 575 ms (-10.12% 🔽) 5.9 s
ECIES encryption 79.15 KB (-0.18% 🔽) 1.6 s (-0.18% 🔽) 440 ms (+39.3% 🔺) 2.1 s
Symmetric encryption 79.16 KB (-0.18% 🔽) 1.6 s (-0.18% 🔽) 351 ms (-14.18% 🔽) 2 s
DNS discovery 110.92 KB (0%) 2.3 s (0%) 278 ms (-38.11% 🔽) 2.5 s
Privacy preserving protocols 131.44 KB (-0.09% 🔽) 2.7 s (-0.09% 🔽) 459 ms (-7.13% 🔽) 3.1 s
Light protocols 81.12 KB (0%) 1.7 s (0%) 224 ms (-15.5% 🔽) 1.9 s
History retrieval protocols 80.22 KB (0%) 1.7 s (0%) 231 ms (-4.61% 🔽) 1.9 s
Deterministic Message Hashing 5.65 KB (0%) 113 ms (0%) 49 ms (-35.48% 🔽) 162 ms

Copy link
Collaborator

@weboko weboko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool!

@danisharora099 danisharora099 merged commit d39d450 into master Oct 13, 2023
@danisharora099 danisharora099 deleted the chore/filter-ping-test branch October 13, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants