Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade nwaku to 0.34.0 and check interop tests #2176

Open
weboko opened this issue Oct 10, 2024 · 4 comments · May be fixed by #2170
Open

chore: upgrade nwaku to 0.34.0 and check interop tests #2176

weboko opened this issue Oct 10, 2024 · 4 comments · May be fixed by #2170
Assignees
@danisharora099
Labels
test Issue related to the test suite with no expected consequence to production code

Comments

@weboko
Copy link
Collaborator

weboko commented Oct 10, 2024

Problem

Old version of nwaku is used in our CI.

Solution

Use latest

Notes
@weboko weboko added the test Issue related to the test suite with no expected consequence to production code label Oct 10, 2024
@weboko weboko added this to Waku Oct 10, 2024
@weboko weboko moved this to In Progress in Waku Oct 10, 2024
@weboko
Copy link
Collaborator Author

weboko commented Oct 10, 2024

Relevant PR - #2170

@weboko weboko mentioned this issue Oct 16, 2024
Open
@weboko weboko moved this from In Progress to To Do in Waku Oct 20, 2024
@weboko weboko moved this from To Do to Priority in Waku Oct 20, 2024
@weboko
Copy link
Collaborator Author

weboko commented Oct 20, 2024

@danisharora099 feel free to move to in progress when you start working on it, I probably misunderstood that you were working on it

@danisharora099 danisharora099 moved this from Priority to In Progress in Waku Nov 29, 2024
@weboko
Copy link
Collaborator Author

weboko commented Dec 9, 2024

@danisharora099 can you, please, share list of breaking changes with nwaku that were identified?

@danisharora099 danisharora099 changed the title chore: upgrade nwaku to 0.33.0 and check interop tests chore: upgrade nwaku to 0.34.0 and check interop tests Jan 17, 2025
@danisharora099
Copy link
Collaborator

@danisharora099 can you, please, share list of breaking changes with nwaku that were identified?

Primary breaking change was identified to be the requirement of nwaku needing at least one peer in its mesh to respond to a lightpush request successfully. A lot of our tests, even if spawned multiple nwaku nodes, didn't expect them to be connected to each other over relay as that not only takes more time for the test to succeed, but was simply not required and something we weren't testing part of the js-waku test suite.

@danisharora099 danisharora099 linked a pull request Jan 22, 2025 that will close this issue
chore: upgrade nwaku to 0.34.0 and update tests suite for compatibility #2170
Open
3 tasks
@danisharora099 danisharora099 linked a pull request Jan 22, 2025 that will close this issue
Open
3 tasks
@danisharora099 danisharora099 moved this from In Progress to Code Review / QA in Waku Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danisharora099 danisharora099

Labels
test Issue related to the test suite with no expected consequence to production code
Projects
Waku
Status: Code Review / QA
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: upgrade nwaku to 0.34.0 and update tests suite for compatibility waku-org/js-waku
2 participants
@danisharora099 @weboko