Hotfix #9
Merged
Hotfix #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The FWakaTimeInstaller is an instance of TWakaTimeCLIInstallerThread that auto free itself when finish, you should never FreeAndNil an instance of TWakaTimeCLIInstallerThread, just clean the reference.
…e IDE was calling the Destroy, causing another invalid pointer operation when closing Delphi or uninstaling the component.
…ile and after compile. We should never manualy create a TSourceEditorNotifier, we have to query the interface from the editor that is already allocated and use its methods to avoid it to never get removed from the memory, and another errors related on the way that each editornotifier removes itself from the SourceEditorNotifiers List.
* Renamed the variable "executable" to "CLIFileName".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6, fixes #5