-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
3 changed files
with
1 addition
and
85 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta" | |
|
||
[project] | ||
name = "waifuvault" | ||
version = "1.2.5" | ||
version = "1.2.6" | ||
authors = [ | ||
{ name="Walker Aldridge", email="[email protected]" }, | ||
] | ||
|
This file was deleted.
Oops, something went wrong.
Binary file not shown.
333b78e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many times I've considered submitting some tests for this .@nakedmcse why did you remove the first draft of tests? API changes too often? I think it would be cool to build tests into the CD pipeline.
333b78e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They worked just fine, but they were tests against the real production server.
They need to be reworked against a mock of the service, and thats a job for the future.
I need to figure out the mocking of calls to the requests library.
333b78e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is exactly why I didn't submit anything!! was curious if running tests against the production server was considered a bad practice.