Skip to content

Commit

Permalink
Remove tests, bump version
Browse files Browse the repository at this point in the history
  • Loading branch information
nakedmcse committed Mar 21, 2024
1 parent df93a66 commit 333b78e
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 85 deletions.
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"

[project]
name = "waifuvault"
version = "1.2.5"
version = "1.2.6"
authors = [
{ name="Walker Aldridge", email="[email protected]" },
]
Expand Down
84 changes: 0 additions & 84 deletions tests/test_waifuvault.py

This file was deleted.

Binary file removed tests/testfile.png
Binary file not shown.

3 comments on commit 333b78e

@weddleben
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many times I've considered submitting some tests for this .@nakedmcse why did you remove the first draft of tests? API changes too often? I think it would be cool to build tests into the CD pipeline.

@nakedmcse
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They worked just fine, but they were tests against the real production server.
They need to be reworked against a mock of the service, and thats a job for the future.
I need to figure out the mocking of calls to the requests library.

@weddleben
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is exactly why I didn't submit anything!! was curious if running tests against the production server was considered a bad practice.

Please sign in to comment.