Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First release #1

Merged
merged 7 commits into from
Mar 25, 2024
Merged

First release #1

merged 7 commits into from
Mar 25, 2024

Conversation

ernestmarcinko
Copy link
Collaborator

Added all endpoints toErnestMarcinko\WaifuVault\WaifuApi

  • uploadFile()
  • getFileInfo()
  • modifyEntry()
  • deleteEntry()

RequestHandler interface

Can be used in combination with the WaifuApi constructor to inject a custom RequestHandler. By default the built-in WaifuRequestHandler is injected, which uses CURL.

Tests

Please verify coverage for both WaifuApi and WaifuRequestHandler, both are tested separately.

How-to test

composer install
composer update
./vendor/bin/phpunit

@ernestmarcinko ernestmarcinko self-assigned this Mar 25, 2024
nakedmcse
nakedmcse approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@nakedmcse nakedmcse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@ernestmarcinko ernestmarcinko merged commit 0713509 into main Mar 25, 2024
1 check passed
@VictoriqueMoe
Copy link
Member

un-Approved

@VictoriqueMoe VictoriqueMoe deleted the dev branch March 25, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nakedmcse nakedmcse nakedmcse approved these changes

@VictoriqueMoe VictoriqueMoe Awaiting requested review from VictoriqueMoe

Assignees

@ernestmarcinko ernestmarcinko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ernestmarcinko @VictoriqueMoe @nakedmcse