Updating electron-builder to a ts file

wahni-green · Jan 25, 2024 · bfa9627 · bfa9627
1 parent f90143a
commit bfa9627
Show file tree

Hide file tree

Showing 3 changed files with 103 additions and 55 deletions.
diff --git a/build/scripts/build.mjs b/build/scripts/build.mjs
@@ -162,13 +162,6 @@ async function packageApp() {
     ...builderArgs,
   };
 
-  /**
-   * electron-builder doesn't look for the APPLE_TEAM_ID environment variable for some reason.
-   * This workaround allows an environment variable to be added to the electron-builder.yml config
-   * collection. See: https://github.com/electron-userland/electron-builder/issues/7812
-   */
-  buildOptions.mac = { notarize: { teamId: process.env.APPLE_TEAM_ID || "" } }
-
   await builder.build(buildOptions);
 }
 

diff --git a/electron-builder.ts b/electron-builder.ts
@@ -0,0 +1,55 @@
+import type { Configuration } from "electron-builder";
+
+  /**
+   * electron-builder doesn't look for the APPLE_TEAM_ID environment variable for some reason.
+   * This workaround allows an environment variable to be added to the electron-builder.yml config
+   * collection. See: https://github.com/electron-userland/electron-builder/issues/7812
+   */
+
+const config: Configuration = {
+  productName: "Frappe Books",
+  appId: "io.frappe.books",
+  asarUnpack: "**/*.node",
+  extraResources: [
+    { from: 'log_creds.txt', to: '../creds/log_creds.txt' },
+    { from: 'translations', to: '../translations' },
+    { from: 'templates', to: '../templates' },
+  ],
+  mac: {
+    type: "distribution",
+    category: "public.app-category.finance",
+    icon: "build/icon.icns",
+    notarize: {
+      teamId: process.env.APPLE_TEAM_ID || ""
+    },
+    hardenedRuntime: true,
+    gatekeeperAssess: false,
+    darkModeSupport: false,
+    entitlements: "build/entitlements.mac.plist",
+    entitlementsInherit: "build/entitlements.mac.plist",
+    publish: [ "github" ]
+  },
+  win: {
+    publisherName: "Frappe Technologies Pvt. Ltd.",
+    signDlls: true,
+    icon: "build/icon.ico",
+    publish: [ "github" ],
+    target: [ "portable", "nsis" ]
+  },
+  nsis: {
+    oneClick: false,
+    perMachine: false,
+    allowToChangeInstallationDirectory: true,
+    installerIcon: "build/installericon.ico",
+    uninstallerIcon: "build/uninstallericon.ico",
+    publish: [ "github" ]
+  },
+  linux: {
+    icon: "build/icons",
+    category: "Finance",
+    publish: [ "github" ],
+    target: [ "deb", "AppImage", "rpm" ]
+  }
+};
+
+export default config;
diff --git a/electron-builder.yml → electron-builder.yml.disabled b/electron-builder.yml → electron-builder.yml.disabled
@@ -1,48 +1,48 @@
-productName: Frappe Books
-appId: io.frappe.books
-asarUnpack: '**/*.node'
-extraResources:
-  [
-    { from: 'log_creds.txt', to: '../creds/log_creds.txt' },
-    { from: 'translations', to: '../translations' },
-    { from: 'templates', to: '../templates' },
-  ]
-mac:
-  type: distribution
-  category: public.app-category.finance
-  icon: build/icon.icns
-  # notarize:
-  #   appBundleId: io.frappe.books
-  hardenedRuntime: true
-  gatekeeperAssess: false
-  darkModeSupport: false
-  entitlements: build/entitlements.mac.plist
-  entitlementsInherit: build/entitlements.mac.plist
-  publish:
-    - github
-win:
-  publisherName: Frappe Technologies Pvt. Ltd.
-  signDlls: true
-  icon: build/icon.ico
-  publish:
-    - github
-  target:
-    - portable
-    - nsis
-nsis:
-  oneClick: false
-  perMachine: false
-  allowToChangeInstallationDirectory: true
-  installerIcon: build/installericon.ico
-  uninstallerIcon: build/uninstallericon.ico
-  publish:
-    - github
-linux:
-  icon: build/icons
-  category: Finance
-  publish:
-    - github
-  target:
-    - deb
-    - AppImage
-    - rpm
+productName: Frappe Books
+appId: io.frappe.books
+asarUnpack: '**/*.node'
+extraResources:
+  [
+    { from: 'log_creds.txt', to: '../creds/log_creds.txt' },
+    { from: 'translations', to: '../translations' },
+    { from: 'templates', to: '../templates' },
+  ]
+mac:
+  type: distribution
+  category: public.app-category.finance
+  icon: build/icon.icns
+  # notarize:
+  #   appBundleId: io.frappe.books
+  hardenedRuntime: true
+  gatekeeperAssess: false
+  darkModeSupport: false
+  entitlements: build/entitlements.mac.plist
+  entitlementsInherit: build/entitlements.mac.plist
+  publish:
+    - github
+win:
+  publisherName: Frappe Technologies Pvt. Ltd.
+  signDlls: true
+  icon: build/icon.ico
+  publish:
+    - github
+  target:
+    - portable
+    - nsis
+nsis:
+  oneClick: false
+  perMachine: false
+  allowToChangeInstallationDirectory: true
+  installerIcon: build/installericon.ico
+  uninstallerIcon: build/uninstallericon.ico
+  publish:
+    - github
+linux:
+  icon: build/icons
+  category: Finance
+  publish:
+    - github
+  target:
+    - deb
+    - AppImage
+    - rpm