Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

알림함에서 강의상세 진입 시 강의평 조회실패 수정 #390

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from
Open

알림함에서 강의상세 진입 시 강의평 조회실패 수정 #390

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
d7f280d
알림함에서 강의 상세 진입 시 Viewing -> Normal
plgafhd Jan 27, 2025
6d6a655
backstack 관련 처리
plgafhd Jan 27, 2025
544e6ee
Merge branch 'develop' into plgafhd/fix-noti-to-ev-fail
plgafhd Feb 24, 2025
54549ec
Revert "알림함에서 강의 상세 진입 시 Viewing -> Normal"
plgafhd Feb 25, 2025
64ab797
Revert "backstack 관련 처리"
plgafhd Feb 25, 2025
1026149
Deeplink로 강의 상세를 열기 전에 getLectureReview() 호출
plgafhd Feb 26, 2025
404acc6
lint
plgafhd Feb 26, 2025
810b945
run 대신 runCatching 사용
plgafhd Mar 5, 2025
c5e5913
runCatching의 onFailure와 getOrElse 통합
plgafhd Mar 8, 2025
b77ff2e
주석 추가
plgafhd Mar 8, 2025
8134af5
주석 수정
plgafhd Mar 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/src/main/java/com/wafflestudio/snutt2/deeplink/DeeplinkExecutor.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ fun InstallInAppDeeplinkExecutor() {

homePageLectureDetailViewModel.initializeEditingLectureDetail(
lectureToShow,
ModeType.Viewing,
ModeType.Normal,
)
withContext(Dispatchers.Main) {
navController.navigate("${NavigationDestination.TimetableLecture}?tableId=$timetableId")
Expand Down
2 changes: 2 additions & 0 deletions ...src/main/java/com/wafflestudio/snutt2/views/logged_in/lecture_detail/LectureDetailPage.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,8 @@ fun LectureDetailPage(
ModeType.Normal -> {
if (navController.currentDestination?.route == NavigationDestination.LectureDetail) {
navController.popBackStack()
} else if (navController.currentDestination?.route?.contains(NavigationDestination.TimetableLecture) == true) {
onCloseViewMode(scope) // 알림함에서 진입하는 경우 다시 알림함으로 돌아가야 함
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

navController.currentDestination?.route == NavigationDestination.LectureDetail 분기의 정체)
뒤로가기 연타하면 흰 화면 보이는? 버그를 막기 위한 코드
요 분기때문에 이 작업에서 TimetableLecture 분기도 추가되어 코드를 이해하기 어려워짐

-> 지금은 발생하지 않는 버그거나 발생하더라도 사소한 수준이라면
요 분기 없애고
Normal, Viewing 통일하고
onCloseViewMode를 항상 넣어줄 수 있도록 코드상에서 강제해본다

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 분기 없애면 강의 상세에서 좌상단의 뒤로가기 버튼이랑 그냥 뒤로가기 동시에 눌렀을 때
하얀 화면 되는 버그 100% 재현 가능한데다 한번 그렇게 되면 앱 나갔다가 들어와도 하얀 화면에 갇혀서,
분기 없애기는 힘든 것 같아
#184 (comment)

}
is ModeType.Editing -> {
Expand Down
Loading