122 6261 #1
Open
122 6261 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add a "source" tag to the job. - Do not provide a comparison_magnitude arg. In pinpoint this defaults to 1.0. We do not have the median_before/after_anomaly fields in the skia anomalies. - Add a small marker on the job title Change-Id: Ibaf3216abf393e40688f00f6c70852cbf46e14e5 Reviewed-on: https://chromium-review.googlesource.com/c/catapult/+/4888772 Reviewed-by: Wenbin Zhang <[email protected]> Commit-Queue: Ashwin Verleker <[email protected]>
Reduce isolate life from 58 days to 30 days, to match upcoming server change. Bug: chromium:1486740 Change-Id: Ibc4285d02ced08036e103fc4fd1f6163d334c6ec Reviewed-on: https://chromium-review.googlesource.com/c/catapult/+/4893255 Commit-Queue: Sean McCullough <[email protected]> Reviewed-by: Sean McCullough <[email protected]> Auto-Submit: John Chen <[email protected]>
Fix the issue that the required labels are removed, such as Pri-X and Type-X, by addding a parameter when generating the components, cc and labels. Also allow subscriptions to opt-out from the delay triage. Currently sandwich subs will still be triaged as the label 'sandwich-sheriff' is needed. Bug: chromium:1471690 Change-Id: I35747833dba7ddec82f1ca5047625d00f27c4a6a Reviewed-on: https://chromium-review.googlesource.com/c/catapult/+/4863928 Reviewed-by: John Chen <[email protected]> Commit-Queue: Wenbin Zhang <[email protected]>
Change-Id: I2099f51b236b1adf68dcf92452ce276c5515d4fe Reviewed-on: https://chromium-review.googlesource.com/c/catapult/+/4897956 Reviewed-by: Wenbin Zhang <[email protected]> Commit-Queue: Ashwin Verleker <[email protected]>
When the list of missing dirs is long, the shell command can fail with error "Argument list too long": http://b/293175593#comment19 Switch missing dir creation to a similar way as that in _UNZIP_AND_CHMOD_SCRIPT Bug: b:293175593, chromium:1174331 Change-Id: Ib9b51eeaa2a877a7753459b1a45e908cfce5542d Reviewed-on: https://chromium-review.googlesource.com/c/catapult/+/4891346 Commit-Queue: Haiyang Pan <[email protected]> Reviewed-by: Ben Pastene <[email protected]>
Bug: chromium:1487320 Change-Id: Id203249a9e12ae88624dfe79ed0b258ebe7df0d4 Reviewed-on: https://chromium-review.googlesource.com/c/catapult/+/4898370 Reviewed-by: Eduardo Yap <[email protected]> Commit-Queue: Wenbin Zhang <[email protected]> Reviewed-by: Sean McCullough <[email protected]>
Bug: chromium:1487320 Change-Id: I6438c2e14ba1e281737b0a7950f2ccd3430a0787 Reviewed-on: https://chromium-review.googlesource.com/c/catapult/+/4898371 Reviewed-by: Eduardo Yap <[email protected]> Reviewed-by: Sean McCullough <[email protected]> Commit-Queue: Wenbin Zhang <[email protected]>
Bug: chromium:1487320 Change-Id: Iac25a8afb768ea21b9aa388d116d33b84910aae3 Reviewed-on: https://chromium-review.googlesource.com/c/catapult/+/4898373 Commit-Queue: Wenbin Zhang <[email protected]> Reviewed-by: Sean McCullough <[email protected]> Reviewed-by: Eduardo Yap <[email protected]>
Bug: chromium:1487320 Change-Id: I0ff7b0fd6db054707e939a3577394ef2750f5ba5 Reviewed-on: https://chromium-review.googlesource.com/c/catapult/+/4898374 Reviewed-by: Eduardo Yap <[email protected]> Reviewed-by: Sean McCullough <[email protected]> Commit-Queue: Wenbin Zhang <[email protected]>
Bug: chromium:1487320 Change-Id: Ia4497484666d534a9526c11f66cc39bb0a09b27f Reviewed-on: https://chromium-review.googlesource.com/c/catapult/+/4898372 Commit-Queue: Wenbin Zhang <[email protected]> Reviewed-by: Sean McCullough <[email protected]> Reviewed-by: Eduardo Yap <[email protected]>
Bug: chromium:1487320 Change-Id: Iaf45fa7c68b067d338898783525999e1647ded15 Reviewed-on: https://chromium-review.googlesource.com/c/catapult/+/4897960 Reviewed-by: Sean McCullough <[email protected]> Commit-Queue: Wenbin Zhang <[email protected]> Reviewed-by: Eduardo Yap <[email protected]>
Extend the current validation logic to multiple story tags. Bug: chromium:1487055 Change-Id: Ib87168c816f0d9db1c5535931ef382b4ac921ca2 Reviewed-on: https://chromium-review.googlesource.com/c/catapult/+/4898368 Reviewed-by: John Chen <[email protected]> Commit-Queue: Wenbin Zhang <[email protected]>
…eated via the arrow button The 'Test a patch' button was not updated to use 'base_patch' or 'experiment_patch' arguments to create a new try job. Instead, it still uses the 'patch' argument. The new try job can still run, but when end user tries to rerun that try job, the 'base_patch' and 'experiment_patch' cannot be populated as they don't exist. This CL renamed the argument used in 'Test a patch' logic. Bug: chromium:1483033 Change-Id: Ib62da7c1c9930a8271baba57dafa9f466c0ea80f Reviewed-on: https://chromium-review.googlesource.com/c/catapult/+/4904934 Reviewed-by: John Chen <[email protected]> Commit-Queue: Wenbin Zhang <[email protected]> Reviewed-by: Sean McCullough <[email protected]>
…ed files." This reverts commit 328888e. Reason for revert: Suspected cause of crbug.com/1487617 Original change's description: > Use scripts to create missing dirctories during pushing changed files. > > When the list of missing dirs is long, the shell command can fail with > error "Argument list too long": http://b/293175593#comment19 > > Switch missing dir creation to a similar way as that in > _UNZIP_AND_CHMOD_SCRIPT > > Bug: b:293175593, chromium:1174331 > Change-Id: Ib9b51eeaa2a877a7753459b1a45e908cfce5542d > Reviewed-on: https://chromium-review.googlesource.com/c/catapult/+/4891346 > Commit-Queue: Haiyang Pan <[email protected]> > Reviewed-by: Ben Pastene <[email protected]> Bug: b:293175593, chromium:1174331 Change-Id: I40b5b4002f0257262c99913d335af9ba4060b03f Reviewed-on: https://chromium-review.googlesource.com/c/catapult/+/4904959 Bot-Commit: Rubber Stamper <[email protected]> Reviewed-by: Haiyang Pan <[email protected]> Commit-Queue: Brian Sheedy <[email protected]>
…ed files." This is a reland of commit 328888e SingleQuote is now called for each dir to escape the potential spaces before passed to the script _MKDIR_SCRIPT. Tested in https://ci.chromium.org/b/8768578666375087713 and works fine Also the same logic is applied to _UNZIP_AND_CHMOD_SCRIPT. Original change's description: > Use scripts to create missing dirctories during pushing changed files. > > When the list of missing dirs is long, the shell command can fail with > error "Argument list too long": http://b/293175593#comment19 > > Switch missing dir creation to a similar way as that in > _UNZIP_AND_CHMOD_SCRIPT > > Bug: b:293175593, chromium:1174331 > Change-Id: Ib9b51eeaa2a877a7753459b1a45e908cfce5542d > Reviewed-on: https://chromium-review.googlesource.com/c/catapult/+/4891346 > Commit-Queue: Haiyang Pan <[email protected]> > Reviewed-by: Ben Pastene <[email protected]> Bug: b:293175593, chromium:1174331, chromium:1487617 Change-Id: Ic2559579b612154ab29a18de12faf49ce47b94e2 Reviewed-on: https://chromium-review.googlesource.com/c/catapult/+/4905951 Commit-Queue: Haiyang Pan <[email protected]> Reviewed-by: Brian Sheedy <[email protected]>
When target_user is set, these methods will: * Resolve the given path(s) * Force the "as_root" to True This aims to move the multi-user logic from android test_runners to device_utils for simplicity. The affected methods are: * PushChangedFiles * PathExists * RemovePath * PullFile * ReadFile * WriteFile * PlaceNomediaFile Bug: b:293175593 Change-Id: I9c0112cd0bcb41b5943babb4ec11ac9fb8c6b4af Reviewed-on: https://chromium-review.googlesource.com/c/catapult/+/4903883 Reviewed-by: Brian Sheedy <[email protected]> Commit-Queue: Haiyang Pan <[email protected]>
These logs are mainly to debug an issue where a Bot is set as public, yet the resulting TestMetadata entities get set to internal. I suspect something is wrong with the Bot.GetInternalOnlySync function. Change-Id: Ida9313ccae24c82faf6e898f25c0daf90db50b5e Reviewed-on: https://chromium-review.googlesource.com/c/catapult/+/4907575 Commit-Queue: Eduardo Yap <[email protected]> Reviewed-by: Wenbin Zhang <[email protected]> Reviewed-by: Ashwin Verleker <[email protected]>
…in the alert group are public - Also move the legacy link up with the skia perf links. Change-Id: I0cfff5b8b5eb630c4aeb302c83b5c0fb80411d39 Reviewed-on: https://chromium-review.googlesource.com/c/catapult/+/4907761 Reviewed-by: Wenbin Zhang <[email protected]> Commit-Queue: Ashwin Verleker <[email protected]>
See the bug for more context but tl;dr this CL aggressively filters out anomalies that span swarming device changes from being processed as alerts that humans need to look into. I got hit with device-change "anomalies" on this past week's on-call rotation, and I got hit with it on my previous rotation too. A recurring source of pain is when, for ...whatever reason... a device that was reporting measurements for some metric on the waterfall is replaced by an entirely different physical device who then proceeds to report that same metric but with a different bias than the previous device that reported it. You end up with a "change" in the timeseries values according to chromeperf, but what it actually reflects is differences in *physical device* performance, not differences in the *code under test*'s performance. This CL: - adds `swarming_bot_id` to `models.graph_data.Row` as an explicit, indexed field. `Row.a_bot_id` exists in a sense already because Row is an `ndb.Expando`, and we have code already that reads and writes the field, but it's not currently indexed and won't show up in ndb queries that use projections, which find_anomalies.py does. - adds `bot_id_before_anomaly` and `bot_id_after_anomaly` to `models.anomaly.Anomaly` to keep track of which devices reported the measurements on either side of the `Anomaly` - updates `find_anomalies.py` to ignore anomalies whose start and end Rows have different, non-None swarming_bot_id values rather than save them for further processing. Bug: chromium:1485723 Change-Id: I34347f1e67a7cb2159cec05c4b87fd6ed115730c Reviewed-on: https://chromium-review.googlesource.com/c/catapult/+/4889182 Reviewed-by: Wenbin Zhang <[email protected]> Commit-Queue: Sean McCullough <[email protected]> Reviewed-by: Ashwin Verleker <[email protected]>
…_utils" This reverts commit 7312f22. Reason for revert: Seems breaking the internal automotive builders Original change's description: > devil: Add the option "target_user" to more methods in device_utils > > When target_user is set, these methods will: > * Resolve the given path(s) > * Force the "as_root" to True > > This aims to move the multi-user logic from android test_runners to > device_utils for simplicity. > > The affected methods are: > * PushChangedFiles > * PathExists > * RemovePath > * PullFile > * ReadFile > * WriteFile > * PlaceNomediaFile > > Bug: b:293175593 > Change-Id: I9c0112cd0bcb41b5943babb4ec11ac9fb8c6b4af > Reviewed-on: https://chromium-review.googlesource.com/c/catapult/+/4903883 > Reviewed-by: Brian Sheedy <[email protected]> > Commit-Queue: Haiyang Pan <[email protected]> Bug: b:293175593 Change-Id: I53e975af890c8b3bcfe6cb38caf016e5b47a84d9 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/catapult/+/4909851 Reviewed-by: Brian Sheedy <[email protected]> Commit-Queue: Haiyang Pan <[email protected]> Bot-Commit: Rubber Stamper <[email protected]>
- This api was originally created to do the skia data upload, but encountered memory issues in prod. - Currently this is not being used as the data upload is done via skia-bridge. Change-Id: I8328de30b1330a03c3693f7f473ebdbf874fa366 Reviewed-on: https://chromium-review.googlesource.com/c/catapult/+/4909861 Reviewed-by: Sean McCullough <[email protected]> Commit-Queue: Ashwin Verleker <[email protected]>
Seeing 502 in ungrouped and noticed an anomaly could be handled multiple times creating multiple bugs for the same subscription. Adding logs to help track the lifecycle of the anomlies. Bug: chromium:1488649 Change-Id: I5b30a082cda1964071a80f231c507e0ad8bb78b3 Reviewed-on: https://chromium-review.googlesource.com/c/catapult/+/4909812 Reviewed-by: John Chen <[email protected]> Auto-Submit: Wenbin Zhang <[email protected]> Commit-Queue: John Chen <[email protected]>
Bug: chromium:1488993 Change-Id: I28851738f117b4c696b1b4d0d27fc001e0aa49b9 Reviewed-on: https://chromium-review.googlesource.com/c/catapult/+/4913473 Reviewed-by: Sean McCullough <[email protected]> Commit-Queue: Eduardo Yap <[email protected]>
Bug: chromium:1488993 Change-Id: I11ac5ce038462113f44f24f6815b3c703cd0c96b Reviewed-on: https://chromium-review.googlesource.com/c/catapult/+/4913475 Reviewed-by: Sean McCullough <[email protected]> Commit-Queue: Eduardo Yap <[email protected]>
Bug: chromium:1488993 Change-Id: Id904bfdac181e4abaaad29338cfcf3b972874778 Reviewed-on: https://chromium-review.googlesource.com/c/catapult/+/4912822 Reviewed-by: Sean McCullough <[email protected]> Commit-Queue: Eduardo Yap <[email protected]>
Bug: chromium:1488993 Change-Id: If8ba22320c5d297b58142a3f11590ae39be2e8e2 Reviewed-on: https://chromium-review.googlesource.com/c/catapult/+/4913474 Reviewed-by: Sean McCullough <[email protected]> Commit-Queue: Eduardo Yap <[email protected]>
Bug: chromium:1488993 Change-Id: Ia344b0fdccef038c6a4115a2da89aa20939faa4f Reviewed-on: https://chromium-review.googlesource.com/c/catapult/+/4912821 Commit-Queue: Eduardo Yap <[email protected]> Reviewed-by: Sean McCullough <[email protected]>
…l devices" This reverts commit 88124d5. Reason for revert: https://b.corp.google.com/issues/303566284#comment3 This is causing errors on prod because it looks like this CL didn't include an update to the DataStore indexes for the new `Row.swarming_bot_id` property. Original change's description: > [chromeperf] ignore "anomalies" measured by different physical devices > > See the bug for more context but tl;dr this CL aggressively filters out anomalies that span swarming device changes from being processed as alerts that humans need to look into. > > I got hit with device-change "anomalies" on this past week's on-call rotation, and I got hit with it on my previous rotation too. > > A recurring source of pain is when, for ...whatever reason... > a device that was reporting measurements for some metric on the > waterfall is replaced by an entirely different physical device who > then proceeds to report that same metric but with a different bias > than the previous device that reported it. > > You end up with a "change" in the timeseries values according to chromeperf, but what it actually reflects is differences in *physical device* performance, not differences in the *code under test*'s performance. > > This CL: > > - adds `swarming_bot_id` to `models.graph_data.Row` as an explicit, indexed field. `Row.a_bot_id` exists in a sense already because Row is an `ndb.Expando`, and we have code already that reads and writes the field, but it's not currently indexed and won't show up in ndb queries that use projections, which find_anomalies.py does. > > - adds `bot_id_before_anomaly` and `bot_id_after_anomaly` to `models.anomaly.Anomaly` to keep track of which devices reported the measurements on either side of the `Anomaly` > > - updates `find_anomalies.py` to ignore anomalies whose start and end Rows have different, non-None swarming_bot_id values rather than save them for further processing. > > Bug: chromium:1485723 > Change-Id: I34347f1e67a7cb2159cec05c4b87fd6ed115730c > Reviewed-on: https://chromium-review.googlesource.com/c/catapult/+/4889182 > Reviewed-by: Wenbin Zhang <[email protected]> > Commit-Queue: Sean McCullough <[email protected]> > Reviewed-by: Ashwin Verleker <[email protected]> Bug: chromium:1485723 Change-Id: I871f2db77663ba03fdb5a5dc028911f68c5e3bff Reviewed-on: https://chromium-review.googlesource.com/c/catapult/+/4917871 Commit-Queue: Sean McCullough <[email protected]> Bot-Commit: Rubber Stamper <[email protected]>
This reverts commit 8d334e0. Reason for revert: Causing anomaly detection to fail for certain tests. Original change's description: > update chromeperf deployment for upload-processing > > Bug: chromium:1488993 > Change-Id: I11ac5ce038462113f44f24f6815b3c703cd0c96b > Reviewed-on: https://chromium-review.googlesource.com/c/catapult/+/4913475 > Reviewed-by: Sean McCullough <[email protected]> > Commit-Queue: Eduardo Yap <[email protected]> Bug: chromium:1488993 Change-Id: If54835aacf3861ec3853b37d4d7a275dfa9ea58a Reviewed-on: https://chromium-review.googlesource.com/c/catapult/+/4917870 Bot-Commit: Rubber Stamper <[email protected]> Reviewed-by: Sean McCullough <[email protected]> Commit-Queue: Eduardo Yap <[email protected]>
Includes the missing index.yaml update discovered in production via b/303566284 [chromeperf] ignore "anomalies" measured by different physical devices See the bug for more context but tl;dr this CL aggressively filters out anomalies that span swarming device changes from being processed as alerts that humans need to look into. I got hit with device-change "anomalies" on this past week's on-call rotation, and I got hit with it on my previous rotation too. A recurring source of pain is when, for ...whatever reason... a device that was reporting measurements for some metric on the waterfall is replaced by an entirely different physical device who then proceeds to report that same metric but with a different bias than the previous device that reported it. You end up with a "change" in the timeseries values according to chromeperf, but what it actually reflects is differences in *physical device* performance, not differences in the *code under test*'s performance. This CL: - adds `swarming_bot_id` to `models.graph_data.Row` as an explicit, indexed field. `Row.a_bot_id` exists in a sense already because Row is an `ndb.Expando`, and we have code already that reads and writes the field, but it's not currently indexed and won't show up in ndb queries that use projections, which find_anomalies.py does. - adds `bot_id_before_anomaly` and `bot_id_after_anomaly` to `models.anomaly.Anomaly` to keep track of which devices reported the measurements on either side of the `Anomaly` - updates `find_anomalies.py` to ignore anomalies whose start and end Rows have different, non-None swarming_bot_id values rather than save them for further processing. Bug: chromium:1485723 Change-Id: Icaf9313e6806c9e03d6fe9f2a554e9b93c70c653 Reviewed-on: https://chromium-review.googlesource.com/c/catapult/+/4919766 Commit-Queue: Sean McCullough <[email protected]> Reviewed-by: Wenbin Zhang <[email protected]>
This reverts commit f582f5b. Reason for revert: b/318818513, and this change is on the top of the https://chromium-review.googlesource.com/c/catapult/+/5163549 that need to be reverted. Original change's description: > cros: Check if LocalState exists before removing > > This should prevent error when LocalState file does not exist. > > BUG: b:318818513 > BUG: b:304961264 > Change-Id: Id0e3e19d1ec68ca27d01a9dfd559742f900d78aa > Reviewed-on: https://chromium-review.googlesource.com/c/catapult/+/5171492 > Commit-Queue: Achuith Bhandarkar <[email protected]> > Reviewed-by: Achuith Bhandarkar <[email protected]> > Reviewed-by: Denis Kuznetsov <[email protected]> Bug: b:318818513 Bug: b:304961264 Change-Id: Id6c821cc4d1d39a012f4d21d6892b43a7146c4cd Reviewed-on: https://chromium-review.googlesource.com/c/catapult/+/5200826 Bot-Commit: Rubber Stamper <[email protected]> Reviewed-by: Danila Kuzmin <[email protected]> Commit-Queue: Denis Kuznetsov <[email protected]>
…ome" This reverts commit 29e1dd0. Reason for revert: This breaks any autotest that uses chrome.Chrome(), like login_LoginSuccess which is used by power_SuspendStress: 13:49:25 INFO | autoserv| START login_LoginSuccess.power_SuspendStress login_LoginSuccess.power_SuspendStress timestamp=1705006164 localtime=Jan 11 13:49:24 13:49:25 INFO | autoserv| Bundling /mnt/host/source/src/third_party/autotest/files/autotest_lib/client/site_tests/login_LoginSuccess into test-login_LoginSuccess.tar.bz2 13:49:28 INFO | autoserv| FAIL login_LoginSuccess.power_SuspendStress login_LoginSuccess.power_SuspendStress timestamp=1705006167 localtime=Jan 11 13:49:27 Unhandled FileNotFoundError: [Errno 2] No such file or directory: '/home/chronos/Local\\ State' 13:49:28 INFO | autoserv| END FAIL login_LoginSuccess.power_SuspendStress login_LoginSuccess.power_SuspendStress timestamp=1705006167 localtime=Jan 11 13:49:27 The following line should not escape the space in the path: local_state_path = r'/home/chronos/Local\ State' Updating to the following fixes this: local_state_path = r'/home/chronos/Local State' Original change's description: > cros: Clean user data from LocalState if test removes cryptohome > > This is the retry attempt for crrev.com/c/5147387, now with > shielded whitespace in the `Local State` filename. > > Bug: b:304961264 > Change-Id: Ib4594c7ed0e2c3b818e21bbf5d8b30550dca5faf > Reviewed-on: https://chromium-review.googlesource.com/c/catapult/+/5163549 > Commit-Queue: Denis Kuznetsov <[email protected]> > Reviewed-by: Mikhail Khokhlov <[email protected]> Bug: b:304961264 Change-Id: I26eb75cc58563ed36e5f5190483e129dac115ce4 Reviewed-on: https://chromium-review.googlesource.com/c/catapult/+/5189873 Reviewed-by: Denis Kuznetsov <[email protected]> Reviewed-by: Danila Kuzmin <[email protected]> Commit-Queue: Denis Kuznetsov <[email protected]> Bot-Commit: Rubber Stamper <[email protected]>
Buganizer only provides hotlist mapping for some of the Monorail labels. During migration, the labels with no mappings will be copied to a custom field in the Buganizer issue. The value of the custom field is 'Monorail Labels' for project Fuchsia, and 'Chromium Labels' for the other projects. Also, the label update in Buganizer is different from Monorail that the new value in the update request will simply override the current value. Thus, we need to load the original values and add/remove from there. Bug: chromium:1447930 Change-Id: Ib5b890ab6ad7eae83c60a989eaa024eb0fb71a2c Reviewed-on: https://chromium-review.googlesource.com/c/catapult/+/5203608 Reviewed-by: John Chen <[email protected]> Reviewed-by: Leina Sun <[email protected]> Commit-Queue: Wenbin Zhang <[email protected]>
Swaps out rmhasan for bsheedy as a typ owner since the former is no longer at the company. Change-Id: I2f79d0487879f5288729ca1768764e2de5adb024 Reviewed-on: https://chromium-review.googlesource.com/c/catapult/+/5201068 Reviewed-by: Dirk Pranke <[email protected]> Auto-Submit: Brian Sheedy <[email protected]> Commit-Queue: Dirk Pranke <[email protected]>
Refactors how the conflict checking function reference is passed around in the TestExpectations class. Previously, it was stored as a member variable, but in practice, that was just used as a hack to avoid passing it through to the method that ultimately used it. Bug: chromium:1502712 Change-Id: I2800023177da74ac80e95faab6af3ed4825b2a8c Reviewed-on: https://chromium-review.googlesource.com/c/catapult/+/5201980 Reviewed-by: Dirk Pranke <[email protected]> Auto-Submit: Brian Sheedy <[email protected]> Commit-Queue: Dirk Pranke <[email protected]>
Changes in this update: https://chromium.googlesource.com/catapult.git/+log/d0442b2..8ebdf90 Bug: chromium:1519203 Change-Id: I0cebc929b41fbf77d01c41dd9ccd9c8cb614f4bc Reviewed-on: https://chromium-review.googlesource.com/c/catapult/+/5207910 Reviewed-by: John Chen <[email protected]> Commit-Queue: Sean McCullough <[email protected]>
Changes in this update: https://chromium.googlesource.com/catapult.git/+log/b6c8e17..6fd04d1 Bug: chromium:1519203 Change-Id: I9d869c4e438cf05368fd06501406ea9fcec86d54 Reviewed-on: https://chromium-review.googlesource.com/c/catapult/+/5207831 Reviewed-by: John Chen <[email protected]> Commit-Queue: Sean McCullough <[email protected]>
Adds support for using custom tag conflict checkers in typ when running SeriallyExecutedBrowserTests in Telemetry. The ability to use a custom checker has existed for a long time, but only when using the expectation parser code directly, not when typ is used to run tests. crrev.com/c/5208211 is a use of this new functionality. Bug: chromium:1502712 Change-Id: I487889ce424b37078562d90f389acde8b962c900 Reviewed-on: https://chromium-review.googlesource.com/c/catapult/+/5208130 Commit-Queue: Dirk Pranke <[email protected]> Auto-Submit: Brian Sheedy <[email protected]> Reviewed-by: Dirk Pranke <[email protected]>
In some cases we need to collect ad-hoc measurements on Story classes that do not derive from PressStory. This change allows us to do so. The code was copied from PressStory. In a followup we should be able to remove that copy. Change-Id: I1cbb42fec0d9c2e6e20a41be364fa215c587f591 Reviewed-on: https://chromium-review.googlesource.com/c/catapult/+/5208133 Auto-Submit: Peter Collingbourne <[email protected]> Reviewed-by: John Chen <[email protected]> Commit-Queue: John Chen <[email protected]>
We add the ability to track events from Shared Storage by implementing handling of "Storage.sharedStorageAccessed" DevTools protocol events in `InspectorStorage` as well as to send requests to DevTools Protocol for the method 'Storage.setSharedStorageTracking' (which can enable or disable tracking based on the parameter). We then use these capabilities to add, by way of `InspectorBackend`, a `Tab` method `WaitForSharedStorageEvents()` that can wait for a list of expected Shared Storage events in a given order. We plan to use above method in perf benchmark tests for Shared Storage that we are currently writing. Information about the new Shared Storage API can be found at the Shared Storage GitHub repo: https://github.com/WICG/shared-storage/blob/main/README.md Bug: chromium:1516507 Change-Id: I0439ee248696b26f4489de9b3be478ef689b6725 Reviewed-on: https://chromium-review.googlesource.com/c/catapult/+/5194425 Commit-Queue: Cammie Smith Barnes <[email protected]> Reviewed-by: John Chen <[email protected]>
by the job name. Then the metrics could filter job type by the information provided through the job names. Change-Id: I52628642a4b657cd290bc1eaba72f45a2d44a0d2 Reviewed-on: https://chromium-review.googlesource.com/c/catapult/+/5214747 Commit-Queue: Alex Sun <[email protected]> Reviewed-by: Leina Sun <[email protected]>
This reverts commit 9f3f9bb. Reason for revert: New tests failed in one build when trying to roll deps: https://ci.chromium.org/ui/p/chromium/builders/try/chromeos-amd64-generic-rel-gtest/11855/overview Need to investigate. Original change's description: > Shared Storage: Add inspector/tab method to wait for events > > We add the ability to track events from Shared Storage by implementing > handling of "Storage.sharedStorageAccessed" DevTools protocol events > in `InspectorStorage` as well as to send requests to DevTools > Protocol for the method 'Storage.setSharedStorageTracking' (which can > enable or disable tracking based on the parameter). > > We then use these capabilities to add, by way of `InspectorBackend`, > a `Tab` method `WaitForSharedStorageEvents()` that can wait for a > list of expected Shared Storage events in a given order. > > We plan to use above method in perf benchmark tests for Shared Storage > that we are currently writing. > > Information about the new Shared Storage API can be found at the > Shared Storage GitHub repo: > https://github.com/WICG/shared-storage/blob/main/README.md > > Bug: chromium:1516507 > Change-Id: I0439ee248696b26f4489de9b3be478ef689b6725 > Reviewed-on: https://chromium-review.googlesource.com/c/catapult/+/5194425 > Commit-Queue: Cammie Smith Barnes <[email protected]> > Reviewed-by: John Chen <[email protected]> Bug: chromium:1516507 Change-Id: I2c1ddffd24edc027891a31bc6cf54b990abb084e No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/catapult/+/5218591 Auto-Submit: Cammie Smith Barnes <[email protected]> Reviewed-by: John Chen <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Commit-Queue: John Chen <[email protected]>
- We can potentially have multiple masters within same alert group if the subscription regex is structured that way. - Modify skia_helper to return multiple urls with label for alert group. - Update the host mapping in skia_helper to get the host based on master. - Add the new instance details in the host mapping in skia_helper. - Add the new instance service accounts to skia-bridge allow lists. Change-Id: I8c2916f87171ae46204e37fd4a0d95e4f1d6c380 Reviewed-on: https://chromium-review.googlesource.com/c/catapult/+/5214748 Commit-Queue: Ashwin Verleker <[email protected]> Reviewed-by: Wenbin Zhang <[email protected]>
Currently Telemetry reports Windows 11 as Windows 10. This CL fixes it. Change-Id: Ibc7c2c0bd2ed11fb1541868473da37ecc4e3ae7e Reviewed-on: https://chromium-review.googlesource.com/c/catapult/+/5137657 Commit-Queue: John Chen <[email protected]> Reviewed-by: Wenbin Zhang <[email protected]>
The metrics may be aggregate by those information to find the failure root cause quickly Change-Id: Ib48b6cfbfdbf873130c0eea8c6e5e1845ead8e92 Reviewed-on: https://chromium-review.googlesource.com/c/catapult/+/5218260 Reviewed-by: Ashwin Verleker <[email protected]> Reviewed-by: Wenbin Zhang <[email protected]> Commit-Queue: Alex Sun <[email protected]>
Bug: chromium:1520496 Change-Id: I7f68e40cd8d0116681acd9055c68504893cdf1cc Reviewed-on: https://chromium-review.googlesource.com/c/catapult/+/5224442 Reviewed-by: John Chen <[email protected]> Commit-Queue: Sean McCullough <[email protected]> Reviewed-by: Wenbin Zhang <[email protected]>
Change-Id: I5570c02b2633c0556d7e7ab8b48c426e59792686 Reviewed-on: https://chromium-review.googlesource.com/c/catapult/+/5301338 Reviewed-by: Srinivas Sista <[email protected]> Auto-Submit: Mikhail Khokhlov <[email protected]> Commit-Queue: Srinivas Sista <[email protected]>
wab712
added
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0