Refactor modbus in #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update fork from master repo
- refactored modbusIn, modbusServer to reduce CC - adjusted tests to suit
|
Hopefully this resolves the remaining issues with the add_write PR which was already merged. Thanks for the opportunity to work with you on this. I think this node will be useful for so many people, and is very approachable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Are there any issues addressed by this pull-request?
What are you doing in this pull-request in general?
fixing linter issues and reducing CC of modbusIn node. Simplifying code to use same callbacks and handlers for read and write functions.
What are possible side-effect?
none that I could see.
Did you write tests and what are you testing?
existing units tests have been fixed (issue where client connection wasn't being closed properly) and pass tests. Tested with separate node-red instance running a client connection to read/write data.