Add definition of RTCEncodedVideoFrameMetadata frameId and dependencies #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aboba, @alvestrand, @fippo PTAL |
fippo
approved these changes
Jan 19, 2024
fippo
reviewed
Jan 20, 2024
There was a problem hiding this comment.
Lets try AV1-RTP-SPEC which seems to be the canonical thing: https://www.specref.org/?q=av1
Co-authored-by: Philipp Hancke <[email protected]>
Co-authored-by: Philipp Hancke <[email protected]>
fippo
reviewed
Jan 24, 2024
| <dd> | ||
| <p> | ||
| An identifier for the encoded frame, monotonically increasing in decode order. Its lower | ||
| 16 bits match the frame_number of the AV1 Dependency Descriptor Header Extension defined in Appendix A of [[?AV1-RTP-SPEC]], if present. |
There was a problem hiding this comment.
Suggested change
| 16 bits match the frame_number of the AV1 Dependency Descriptor Header Extension defined in Appendix A of [[?AV1-RTP-SPEC]], if present. | |
| 16 bits match the frame_number of the AV1 Dependency Descriptor Header Extension defined in Appendix A of [[AV1-RTP-SPEC]], if present. |
There was a problem hiding this comment.
W3C doesn't like normative dependencies on specs that are IPR-targets. If we can get away with this being an informative dependency, we may prefer that.
| <dd> | ||
| <p> | ||
| List of frameIds of frames this frame references. | ||
| Only present for received frames if the AV1 Dependency Descriptor Header Extension defined in Appendix A of [[?AV1-RTP-SPEC]] is present. |
There was a problem hiding this comment.
Suggested change
| Only present for received frames if the AV1 Dependency Descriptor Header Extension defined in Appendix A of [[?AV1-RTP-SPEC]] is present. | |
| Only present for received frames if the AV1 Dependency Descriptor Header Extension defined in Appendix A of [[AV1-RTP-SPEC]] is present. |
henbos
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue #220
Preview | Diff