-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reuse WebCodec audio/video chunk definitions #101
base: main
Are you sure you want to change the base?
Conversation
readonly attribute ArrayBuffer data; | ||
}; | ||
|
||
// WebCodecs definitions with introduction of EncodedMediaChunk to more easily refer to timestamp and data. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't this be brought directly back to WebCodecs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer we get agreement on the strategy first, like get agreement to reuse WebCodecs constructs, then start discussing with WebCodecs how we can best do things.
With regards to EncodedMediaChunk, I did not think about it to hard, we might want to use a mixin instead of inheritance.
"empty", | ||
interface mixin EncodedMediaChunk { | ||
readonly attribute unsigned long long timestamp; // microseconds | ||
readonly attribute ArrayBuffer data; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that I look at it, data is readonly here but we want to be able to change it in RTCRtpSFrameTransform transforms.
Discussed with @aboba, and the plan might be to remove all encoded audio/video frames but leave RTP metadata specific bits, for instance as partial dictionaries. |
Related WebCodecs issues: |
Initial try at fixing #99
Preview | Diff