Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3984 labels descriptions #4212

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

3984 labels descriptions #4212

wants to merge 21 commits into from

Conversation

mbgower
Copy link
Contributor

@mbgower mbgower commented Jan 29, 2025

Closes #3984 by incorporating the idea of accuracy into 2.4.6 Headings and Labels, and reinforcing the relationship between 2.4.6 and 3.3.2 Labels or Instructions

put Success Criterion lower case except where it specifies a number, as per https://github.com/w3c/wcag/wiki/WCAG-2-style-guide
This reverts commit 7bdeee0.
change "this" to "that"; made dashes be em dashes (without spaces)
Copy link

netlify bot commented Jan 29, 2025

Deploy Preview for wcag2 ready!

Name Link
🔨 Latest commit 84e6567
🔍 Latest deploy log https://app.netlify.com/sites/wcag2/deploys/67c2333c3f00f10008a7bd59
😎 Deploy Preview https://deploy-preview-4212--wcag2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

added "accuracy" to several examples and passages
@mbgower mbgower marked this pull request as ready for review January 29, 2025 22:32
@w3c w3c deleted a comment from ashstone1 Feb 23, 2025
@TestPartners
Copy link

A semi-colon would be a more appropriate separator than a dash or hyphen.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no improvement changing xxx - xxx to xxx-xxx.

@patrickhlauke
Copy link
Member

I see no improvement changing xxx - xxx to xxx-xxx.

for context, the change here uses an actual dash character rather than a - minus sign. and in traditional typography, there's no spaces around dashes (or rather, generally you'd want a hairline space)

@patrickhlauke
Copy link
Member

x-ref #4096

@patrickhlauke patrickhlauke self-assigned this Feb 28, 2025
@patrickhlauke
Copy link
Member

discussed in backlog meeting - opted to reintroduce the spaces around the dashes (even though it does break the "proper" typographic rules, but improves readability)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restore the need for accuracy/correctness to 3.3.2 Labels or Instructions
4 participants