Skip to content

Commit

Permalink
Don't fire textInput when pressing Enter in <input>
Browse files Browse the repository at this point in the history
  • Loading branch information
@zcorpan
zcorpan committed Feb 8, 2024
1 parent 6f9bf88 commit b49c66d
Show file tree
Hide file tree
Showing 2 changed files with 29 additions and 5 deletions.
11 changes: 9 additions & 2 deletions event-algo.bs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -888,6 +888,9 @@ Issue: TODO
1. If |key| is "Delete", then |inputType| = "deleteContentForward"
1. Otherwise,
1. |inputType| = "insertText"

Issue: |inputType| should be "insertParagraph" or "insertLineBreak" when pressing Enter.

1. |data| = |key|

1. If |inputType| is not null, then
Expand All @@ -898,8 +901,12 @@ Issue: TODO
1. Let |result| = <a>fire an InputEvent</a> with "beforeinput", |inputType| and |data|
1. If |result| is false, then return.
1. Let |textInputData| be |data|.
1. If |inputType| is either "insertParagraph" or "insertLineBreak", then set |textInputData| to "\n".
1. If |inputType| is "insertText", then
1. Let |shouldFireTextInput| to true.
1. If |inputType| is either "insertParagraph" or "insertLineBreak", then:
1. Set |textInputData| to "\n".
1. If |target| is an {{HTMLInputElement}}, then set |shouldFireTextInput| to false.
1. If |inputType| is not one of "insertText", "insertParagraph" or "insertLineBreak", then set |shouldFireTextInput| to false.
1. If |shouldFireTextInput| is true, then:

1. Set |result| = <a>fire a TextEvent</a> with "textInput", and |textInputData|

Expand Down
23 changes: 20 additions & 3 deletions event-algo.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1489,7 +1489,7 @@
}
</style>
<meta content="Bikeshed version 4416b18d5, updated Tue Jan 2 15:52:39 2024 -0800" name="generator">
<meta content="cf1f109718ad2176bc07a48d947497c9b4ac56bf" name="revision">
<meta content="651983daa1c07094fecddc3dbdcf621b62b236e2" name="revision">
<style>/* Boilerplate: style-autolinks */
.css.css, .property.property, .descriptor.descriptor {
color: var(--a-normal-text);
Expand Down Expand Up @@ -3175,6 +3175,9 @@ <h3 class="heading settled" data-level="8.3" id="fire key input events"><span cl
<ol>
<li data-md>
<p><var>inputType</var> = "insertText"</p>
</ol>
<p class="issue" id="issue-7c029583"><a class="self-link" href="#issue-7c029583"></a> <var>inputType</var> should be "insertParagraph" or "insertLineBreak" when pressing Enter.</p>
<ol>
<li data-md>
<p><var>data</var> = <var>key</var></p>
</ol>
Expand All @@ -3190,9 +3193,19 @@ <h3 class="heading settled" data-level="8.3" id="fire key input events"><span cl
<li data-md>
<p>Let <var>textInputData</var> be <var>data</var>.</p>
<li data-md>
<p>If <var>inputType</var> is either "insertParagraph" or "insertLineBreak", then set <var>textInputData</var> to "\n".</p>
<p>Let <var>shouldFireTextInput</var> to true.</p>
<li data-md>
<p>If <var>inputType</var> is either "insertParagraph" or "insertLineBreak", then:</p>
<ol>
<li data-md>
<p>Set <var>textInputData</var> to "\n".</p>
<li data-md>
<p>If <var>target</var> is an <code class="idl"><a data-link-type="idl" href="https://html.spec.whatwg.org/multipage/input.html#htmlinputelement" id="ref-for-htmlinputelement">HTMLInputElement</a></code>, then set <var>shouldFireTextInput</var> to false.</p>
</ol>
<li data-md>
<p>If <var>inputType</var> is not one of "insertText", "insertParagraph" or "insertLineBreak", then set <var>shouldFireTextInput</var> to false.</p>
<li data-md>
<p>If <var>inputType</var> is "insertText", then</p>
<p>If <var>shouldFireTextInput</var> is true, then:</p>
<ol>
<li data-md>
<p>Set <var>result</var> = <a data-link-type="dfn" href="#fire-a-textevent①" id="ref-for-fire-a-textevent①">fire a TextEvent</a> with "textInput", and <var>textInputData</var></p>
Expand Down Expand Up @@ -4887,6 +4900,7 @@ <h3 class="no-num no-ref heading settled" id="index-defined-elsewhere"><span cla
<li>
<a data-link-type="biblio">[HTML]</a> defines the following terms:
<ul>
<li><span class="dfn-paneled" id="83b269de">HTMLInputElement</span>
<li><span class="dfn-paneled" id="5d7209e9">Window</span>
<li><span class="dfn-paneled" id="59928beb">click focusable</span>
<li><span class="dfn-paneled" id="1372f92a">dispatch</span>
Expand Down Expand Up @@ -4999,6 +5013,7 @@ <h2 class="no-num no-ref heading settled" id="issues-index"><span class="content
<div class="issue"> Handle historical keypress event here. Return if cancelled. <a class="issue-return" href="#issue-7ecf840c" title="Jump to section">↵</a></div>
<div class="issue"> How much of this can be moved into the [[Input Events]] spec?
Issue: List more keys here <a class="issue-return" href="#issue-10cc14f1" title="Jump to section">↵</a></div>
<div class="issue"> <var>inputType</var> should be "insertParagraph" or "insertLineBreak" when pressing Enter. <a class="issue-return" href="#issue-7c029583" title="Jump to section">↵</a></div>
<div class="issue"> What about target ranges? Need to add support here. <a class="issue-return" href="#issue-3dc727e9" title="Jump to section">↵</a></div>
<div class="issue"> The target for input events should consider focus, but should also ensure that
the element is editable and being modified.
Expand Down Expand Up @@ -5304,6 +5319,7 @@ <h2 class="no-num no-ref heading settled" id="issues-index"><span class="content
"6b3c3a50": {"dfnID":"6b3c3a50","dfnText":"in passive listener flag","external":true,"refSections":[{"refs":[{"id":"ref-for-in-passive-listener-flag"}],"title":"3.2. initialize an Event"}],"url":"https://dom.spec.whatwg.org/#in-passive-listener-flag"},
"7ed32311": {"dfnID":"7ed32311","dfnText":"viewport","external":true,"refSections":[{"refs":[{"id":"ref-for-viewport"}],"title":"6.3. initialize a MouseEvent"}],"url":"https://www.w3.org/TR/CSS2/visuren.html#viewport"},
"838900a7": {"dfnID":"838900a7","dfnText":"isTrusted","external":true,"refSections":[{"refs":[{"id":"ref-for-dom-event-istrusted"}],"title":"3.2. initialize an Event"},{"refs":[{"id":"ref-for-dom-event-istrusted\u2460"}],"title":"4.2. initialize a UIEvent"}],"url":"https://dom.spec.whatwg.org/#dom-event-istrusted"},
"83b269de": {"dfnID":"83b269de","dfnText":"HTMLInputElement","external":true,"refSections":[{"refs":[{"id":"ref-for-htmlinputelement"}],"title":"8.3. fire key input events"}],"url":"https://html.spec.whatwg.org/multipage/input.html#htmlinputelement"},
"895b90c9": {"dfnID":"895b90c9","dfnText":"compositionend","external":true,"refSections":[{"refs":[{"id":"ref-for-compositionend"}],"title":"11.1.1. Window-Level State"}],"url":"https://www.w3.org/TR/uievents/#compositionend"},
"8b547cc7": {"dfnID":"8b547cc7","dfnText":"composed","external":true,"refSections":[{"refs":[{"id":"ref-for-dom-event-composed"}],"title":"3.2. initialize an Event"},{"refs":[{"id":"ref-for-dom-event-composed\u2460"},{"id":"ref-for-dom-event-composed\u2461"}],"title":"6.12. handle native mouse move"}],"url":"https://dom.spec.whatwg.org/#dom-event-composed"},
"8c407366": {"dfnID":"8c407366","dfnText":"cancelable","external":true,"refSections":[{"refs":[{"id":"ref-for-dom-event-cancelable"}],"title":"3.2. initialize an Event"},{"refs":[{"id":"ref-for-dom-event-cancelable\u2460"},{"id":"ref-for-dom-event-cancelable\u2461"}],"title":"6.12. handle native mouse move"},{"refs":[{"id":"ref-for-dom-event-cancelable\u2462"}],"title":"9.1. TextEvent Interface"}],"url":"https://dom.spec.whatwg.org/#dom-event-cancelable"},
Expand Down Expand Up @@ -5980,6 +5996,7 @@ <h2 class="no-num no-ref heading settled" id="issues-index"><span class="content
"https://html.spec.whatwg.org/#click-focusable": {"export":true,"for_":[],"level":"","normative":true,"shortname":"html","spec":"html","status":"anchor-block","text":"click focusable","type":"dfn","url":"https://html.spec.whatwg.org/#click-focusable"},
"https://html.spec.whatwg.org/#focusable-area": {"export":true,"for_":[],"level":"","normative":true,"shortname":"html","spec":"html","status":"anchor-block","text":"focusable area","type":"dfn","url":"https://html.spec.whatwg.org/#focusable-area"},
"https://html.spec.whatwg.org/#focusing-steps": {"export":true,"for_":[],"level":"","normative":true,"shortname":"html","spec":"html","status":"anchor-block","text":"focusing steps","type":"dfn","url":"https://html.spec.whatwg.org/#focusing-steps"},
"https://html.spec.whatwg.org/multipage/input.html#htmlinputelement": {"export":true,"for_":[],"level":"1","normative":true,"shortname":"html","spec":"html","status":"current","text":"HTMLInputElement","type":"interface","url":"https://html.spec.whatwg.org/multipage/input.html#htmlinputelement"},
"https://html.spec.whatwg.org/multipage/nav-history-apis.html#window": {"export":true,"for_":[],"level":"1","normative":true,"shortname":"html","spec":"html","status":"current","text":"Window","type":"interface","url":"https://html.spec.whatwg.org/multipage/nav-history-apis.html#window"},
"https://w3c.github.io/pointerevents/#dom-pointerevent": {"export":true,"for_":[],"level":"3","normative":true,"shortname":"pointerevents","spec":"pointerevents3","status":"current","text":"PointerEvent","type":"interface","url":"https://w3c.github.io/pointerevents/#dom-pointerevent"},
"https://w3c.github.io/uievents/#compositionevent": {"export":true,"for_":[],"level":"1","normative":true,"shortname":"uievents","spec":"uievents","status":"current","text":"CompositionEvent","type":"interface","url":"https://w3c.github.io/uievents/#compositionevent"},
Expand Down

0 comments on commit b49c66d

Please sign in to comment.