Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify that RP can use its own credentials even if extension not specified #272

Merged
merged 26 commits into from
Nov 18, 2024
Merged

Clarify that RP can use its own credentials even if extension not specified #272

merged 26 commits into from
Nov 18, 2024

Conversation

ianbjacobs
Copy link
Collaborator

@ianbjacobs ianbjacobs commented Aug 13, 2024 •
edited by pr-preview bot
Loading

Make clear that an RP should be able to use its own credentials even if payment extension not specified.

Preview | Diff

stephenmcgruer
stephenmcgruer reviewed Nov 15, 2024
View reviewed changes
scope.md Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
stephenmcgruer
stephenmcgruer approved these changes Nov 18, 2024
View reviewed changes
Copy link
Collaborator

@stephenmcgruer stephenmcgruer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one nit. Thank you!

spec.bs Outdated Show resolved Hide resolved
@stephenmcgruer stephenmcgruer merged commit a84dda6 into main Nov 18, 2024
3 checks passed
@stephenmcgruer stephenmcgruer deleted the rp-credentials-enabled branch November 18, 2024 16:00
github-actions bot added a commit that referenced this pull request Nov 18, 2024
@ianbjacobs @github-actions
Clarify that RP can use its own credentials even if extension not spe…
2b24ea8 
…cified (#272)

SHA: a84dda6
Reason: push, by stephenmcgruer

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Nov 18, 2024
@ianbjacobs @github-actions
Clarify that RP can use its own credentials even if extension not spe…
5e262cb 
…cified (#272)

SHA: a84dda6
Reason: push, by stephenmcgruer

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephenmcgruer stephenmcgruer stephenmcgruer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ianbjacobs @stephenmcgruer