(closes #555) Fall back to default logic in `useNativeTypes` mode for RDF numbers which are not JSON numbers #625

anatoly-scherbakov · 2025-01-12T18:57:04Z

This is my second attempt to fix this issue after #619.

Preview | Diff

gkellogg

Minor changes, but this direction seems like the way to go.

index.html

anatoly-scherbakov · 2025-01-15T17:20:03Z

Todo: implement <ins> & <del> tags

w3cbot · 2025-01-15T17:54:38Z

This was discussed during the #json-ld meeting on 15 January 2025.

View the transcript

w3c/json-ld-api#625

anatoly-scherbakov: this is the new version of w3c/json-ld-api#619 ; thanks gkellogg and pchampin for your suggestions.

gkellogg: it's a fairly small change.
… However, it is not purely editorial, so it should be turned into a candidate amendment, with <ins>s, <del>s...
… It has to be done manually, not much automation is available for that.

anatoly-scherbakov: I can not wrap a whole block in <ins> or <del>, right?

bigbluehat: correct, they are 'inline'. Is there a specific class to use?

gkellogg: there are other things to put in place. Respec documentation for them is not great, but there are examples in the same doc.

anatoly-scherbakov: what is the use-case for this marking?

gkellogg: it is there for reviewers of the specification, because we are editing a published Recommendation.

anatoly-scherbakov: an HTML diff will not be enough for the reviewers?

gkellogg: no, they do not expect to look at HTML raw code.
… You can look at the W3C process documents that describes the requirements for these things.

<gkellogg> https://www.w3.org/policies/process/#candidate-amendments

bigbluehat: this is required until we recharter. The alternative is to keep a bunch of open PR and merge them only after we recharter.
… I don't know why TallTed's tick is not green.
… In the DID WG, we are using a list of code owners.

gkellogg · 2025-01-25T19:05:03Z

There’s additional markup needed to show the controls for candidate change ins/del.

gkellogg

I added the other markup necessary, and called it Candidate Correction 5.

index.html

anatoly-scherbakov · 2025-01-27T18:02:09Z

Thanks for reviews!

I still can't merge the PR though 🤔

…ted to JSON number, fall back to default logic

…iveTypes` mode

…hanges.

gkellogg · 2025-01-27T22:44:55Z

Needs a review from @pchampin.

pchampin

Sorry for the delay. I'm approving this PR because the spec text now looks good, and to avoid more delay in back-and-forth...

However, the new test must be amended per my comment, as currently it is both buggy and non-compliant.

pchampin · 2025-01-29T13:43:45Z

tests/fromRdf/0027-out.jsonld

+        },
+        {
+          "@type": "http://www.w3.org/2001/XMLSchema#decimal",
+          "@value": 1.1


Suggested change

},

{

"@type": "http://www.w3.org/2001/XMLSchema#decimal",

"@value": 1.1

This must be removed for two reasons:

the spec only tells to convert xsd:integer and xsd:double, and for a good reason (see below), so this part of the test is actually not complying with the spec;

xsd:decimals should never be converted to JSON native number because they do not round-trip: this one is converted back to "1.1E0"^^xsd:decimal, which is ill-formed (xsd:decimal does not support scientific notation in its lexical space).

pchampin · 2025-01-29T13:44:20Z

tests/fromRdf/0027-in.nq

+<http://example.com/boolean-object> <http://example.com/example> "False"^^<http://www.w3.org/2001/XMLSchema#boolean> .
+
+<http://example.com/number-native> <http://example.com/example> "1"^^<http://www.w3.org/2001/XMLSchema#integer> .
+<http://example.com/number-native> <http://example.com/example> "1.1"^^<http://www.w3.org/2001/XMLSchema#decimal> .


Suggested change

<http://example.com/number-native> <http://example.com/example> "1.1"^^<http://www.w3.org/2001/XMLSchema#decimal> .

Must be removed (see my comment on 0027-out.jsonld below).

TallTed

Tiny language fixes

TallTed · 2025-01-29T18:58:08Z

index.html

@@ -5456,6 +5456,12 @@ <h3>Algorithm</h3>
            <li>Initialize <var>converted value</var> to <var>value</var>.</li>
            <li>Initialize <var>type</var> to <code>null</code></li>
            <li>If <a data-link-for="JsonLdOptions">useNativeTypes</a> is <code>true</code>
+              <div class="candidate correction" id="change_5">
+                <span class="marker">Candidate Correction 5</span>
+                <p>This changes the behavior of using native numbers when <a data-link-for="JsonLdOptions">useNativeTypes</a> is `true`.


Suggested change

<p>This changes the behavior of using native numbers when <a data-link-for="JsonLdOptions">useNativeTypes</a> is `true`.

<p>This changes behavior when using native numbers where <a data-link-for="JsonLdOptions">useNativeTypes</a> is `true`.

TallTed · 2025-01-29T18:58:44Z

index.html

+                    <ol>
+                      <li>
+                        Attempt to convert the <a>lexical form</a> to a <a>JSON number</a>
+                        according to


Suggested change

according to

according to the

anatoly-scherbakov linked an issue Jan 12, 2025 that may be closed by this pull request

blind spot in RDF to object conversion #555

Open

anatoly-scherbakov requested review from pchampin and gkellogg January 12, 2025 18:57

anatoly-scherbakov mentioned this pull request Jan 12, 2025

RDF to Object conversion (closing #555) #619

Closed

gkellogg requested changes Jan 12, 2025

View reviewed changes

index.html Outdated Show resolved Hide resolved

index.html Outdated Show resolved Hide resolved

anatoly-scherbakov force-pushed the 555-blind-spot-in-rdf-to-object-conversion branch from fd7684b to 3b61a1b Compare January 13, 2025 19:52

anatoly-scherbakov requested a review from gkellogg January 13, 2025 19:54

TallTed reviewed Jan 14, 2025

View reviewed changes

index.html Outdated Show resolved Hide resolved

anatoly-scherbakov requested a review from TallTed January 15, 2025 09:21

TallTed approved these changes Jan 15, 2025

View reviewed changes

BigBlueHat added the class-3 Class-3 change label Jan 15, 2025

anatoly-scherbakov requested a review from TallTed January 25, 2025 18:37

gkellogg approved these changes Jan 25, 2025

View reviewed changes

anatoly-scherbakov commented Jan 26, 2025

View reviewed changes

index.html Show resolved Hide resolved

gkellogg mentioned this pull request Jan 26, 2025

Resolve the questions about "JSON Serialization" term #608

Merged

gkellogg and others added 8 commits January 27, 2025 14:42

#555 .gitignore JetBrains & pyenv files

8baaa1d

#555 If useNativeTypes is true but an RDF number cannot be conver…

10590b9

…ted to JSON number, fall back to default logic

#555 fromRdf-manifest.jsonld#t0027 covers fallback logic in `useNat…

f885de0

…iveTypes` mode

Automated report generation

9c402fd

#555 Introduce 2.4.3.3 in value conversion algorithm

a7c2291

#555 Fix punctuation in list

9b2e73e

#555 Insert <ins> tags as appropriate

2affadb

Add Candidate Correction change entry and anchor for useNativeTypes c…

33a652b

…hanges.

gkellogg force-pushed the 555-blind-spot-in-rdf-to-object-conversion branch from 62e7730 to 33a652b Compare January 27, 2025 22:44

pchampin approved these changes Jan 29, 2025

View reviewed changes

TallTed suggested changes Jan 29, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

(closes #555) Fall back to default logic in `useNativeTypes` mode for RDF numbers which are not JSON numbers #625

(closes #555) Fall back to default logic in `useNativeTypes` mode for RDF numbers which are not JSON numbers #625

anatoly-scherbakov commented Jan 12, 2025 •

edited by pr-preview bot

Loading

gkellogg left a comment

anatoly-scherbakov commented Jan 15, 2025 •

edited

Loading

w3cbot commented Jan 15, 2025

w3c/json-ld-api#625

gkellogg commented Jan 25, 2025

gkellogg left a comment

anatoly-scherbakov commented Jan 27, 2025

gkellogg commented Jan 27, 2025

pchampin left a comment

pchampin Jan 29, 2025

pchampin Jan 29, 2025

TallTed left a comment

TallTed Jan 29, 2025

TallTed Jan 29, 2025

	<p>This changes the behavior of using native numbers when <a data-link-for="JsonLdOptions">useNativeTypes</a> is `true`.
	<p>This changes behavior when using native numbers where <a data-link-for="JsonLdOptions">useNativeTypes</a> is `true`.

(closes #555) Fall back to default logic in useNativeTypes mode for RDF numbers which are not JSON numbers #625

Are you sure you want to change the base?

(closes #555) Fall back to default logic in useNativeTypes mode for RDF numbers which are not JSON numbers #625

Conversation

anatoly-scherbakov commented Jan 12, 2025 • edited by pr-preview bot Loading

gkellogg left a comment

Choose a reason for hiding this comment

anatoly-scherbakov commented Jan 15, 2025 • edited Loading

w3cbot commented Jan 15, 2025

w3c/json-ld-api#625

gkellogg commented Jan 25, 2025

gkellogg left a comment

Choose a reason for hiding this comment

anatoly-scherbakov commented Jan 27, 2025

gkellogg commented Jan 27, 2025

pchampin left a comment

Choose a reason for hiding this comment

pchampin Jan 29, 2025

Choose a reason for hiding this comment

pchampin Jan 29, 2025

Choose a reason for hiding this comment

TallTed left a comment

Choose a reason for hiding this comment

TallTed Jan 29, 2025

Choose a reason for hiding this comment

TallTed Jan 29, 2025

Choose a reason for hiding this comment

(closes #555) Fall back to default logic in `useNativeTypes` mode for RDF numbers which are not JSON numbers #625

(closes #555) Fall back to default logic in `useNativeTypes` mode for RDF numbers which are not JSON numbers #625

anatoly-scherbakov commented Jan 12, 2025 •

edited by pr-preview bot

Loading

anatoly-scherbakov commented Jan 15, 2025 •

edited

Loading