Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add candidate change and insertions relating to previously merged class-3 changes. #616

Merged
merged 7 commits into from
Oct 24, 2024

Conversation

gkellogg
Copy link
Member

@gkellogg gkellogg commented Oct 18, 2024

for #380/#388, #514/#528, #565/#566. and #603/#606.

Reorganizes the change log with latest changes first. Comments out some entries in the change log which are class-1 or class-2 changes.


Preview | Diff

@gkellogg
Copy link
Member Author

@iherman I tried to follow the form from EPub 3.3; please suggest ways to improve this.

In addition to other changes in the Project page, there are other comments in the Changes since 1.1 REC section that we'll probably need to investigate, but I want to get the basic form for such changes right.

@iherman
Copy link
Member

iherman commented Oct 18, 2024

Thanks @gkellogg, it looks good to me. I only have two minor comments:

  1. This may be an omission: the EPUB Status section highlights the candidate corrections' style much more visibly than what you have done. I think this should indeed be more visible.
  2. (This may be a matter of taste): the EPUB Changes section clearly separates the substantive changes. This may become very useful when you have to start a horizontal review on the candidate changes, for example.

@gkellogg
Copy link
Member Author

Be commenting out all the editorial changes, we could remove the Changes since Proposed Recommendation Release of 7 May 2020 detail.

Copy link
Member

@iherman iherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still miss an entry for the changes since july 2020, containing these candidate changes. This will become very handy later...

@gkellogg
Copy link
Member Author

The last details entry in the change log appendix includes changes since REC. only the second one, which is the target of this PR, references the actual change block. I updates our changes section based on EPub.

@iherman
Copy link
Member

iherman commented Oct 19, 2024

The last details entry in the change log appendix includes changes since REC. only the second one, which is the target of this PR, references the actual change block. I updates our changes section based on EPub.

Oops, sorry! For some reasons I expected the entries being in a reverse chronological order:-) My bad.

Renumber this change to CANDIDATE CORRECTION 2, as it is ordinally the second change noted in the Changes since Rec detail.
…ithm.

Re-number the change for the expansion algorithm to candidate correction 1.
Comment out 2021-02-25 editorial changes to IRI expansion algorithm.
@gkellogg gkellogg changed the title Add candidate change and insertions relating to scoped-contexts on @nest alias Add candidate change and insertions relating to previously merged class-3 changes. Oct 20, 2024
Copy link
Contributor

@pchampin pchampin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @gkellogg, that looks great.

Note that the PR-preview has a number of Respec issues: defined terms for which Respec fails to create a link (e.g. "active context" or "included blocks"), but this seems to be an artifact of PR-preview (I don't have the issue when I open this PR locally).

@gkellogg
Copy link
Member Author

Note that the PR-preview has a number of Respec issues: defined terms for which Respec fails to create a link (e.g. "active context" or "included blocks"), but this seems to be an artifact of PR-preview (I don't have the issue when I open this PR locally).

We'll need a separate pass to go through ReSpec issues, as it has changed its criteria since we last published.

@gkellogg gkellogg merged commit b8ac517 into main Oct 24, 2024
3 checks passed
@gkellogg gkellogg deleted the insdel-scoped-contexts-on-nest branch October 24, 2024 16:15
@gkellogg
Copy link
Member Author

Note that the PR-preview has a number of Respec issues: defined terms for which Respec fails to create a link (e.g. "active context" or "included blocks"), but this seems to be an artifact of PR-preview (I don't have the issue when I open this PR locally).

I believe the reason for this is that we include files that have the definitions, which PR-preview doesn't have access to, so they look like references to undefined definitions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants