Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable /TR/ publication for errata.html #158

Merged
merged 3 commits into from
Jun 4, 2024

Conversation

himorin
Copy link
Contributor

@himorin himorin commented Jun 4, 2024

This will solve recent PR merge check issues, with removing W3C_ lines.
Also fixed errata.html on wrong repository name, etc.

Background:

  • built spec page (Overview.html) points to errata.html at github.io but not in the same directory in /TR/
  • there seems no available specStatus configuration of respec, which could be published to /TR/, like base nor LD
  • even if we want to publish errata.html into /TR/ we shall run echidna publication at once contains both Overview.html and errata.html (but not running spec-prod twice)

@himorin
Copy link
Contributor Author

himorin commented Jun 4, 2024

mm.. errata label does not exist??

@marcoscaceres marcoscaceres merged commit 71242b6 into main Jun 4, 2024
2 of 3 checks passed
@marcoscaceres marcoscaceres deleted the himorin/disable-tr-errata branch June 4, 2024 13:22
github-actions bot added a commit that referenced this pull request Jun 4, 2024
SHA: 71242b6
Reason: push, by marcoscaceres

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@marcoscaceres
Copy link
Member

Added label (but obviously don’t expect it will be used) https://github.com/w3c/geolocation-api/labels/errata

@himorin
Copy link
Contributor Author

himorin commented Jun 4, 2024

hrm, action for errata still failed, and considering errata.html in gh-pages branch has updated with one using respec ( df64beb ), is it safe to remove gh-action for errata.html completely??

@marcoscaceres
Copy link
Member

It might be… need to talk to @sidvishnoi to see why spec prod is not doing the right thing.

@sidvishnoi
Copy link
Member

In errata.html, there's this function which removes .head details before save. But ReSpec is trying to open that details before save.

https://github.com/w3c/geolocation-api/blob/b358dada8494840877057a71fe39e179a409a99e/errata.html#L39-L44

https://github.com/w3c/respec/blob/df9bb436b8c6cf0e9be2e51e637b24c0fb7f3465/src/w3c/templates/headers.js#L188-L194

I'll send ReSpec PR so it doesn't crash on this unexpected DOM state.

github-actions bot added a commit that referenced this pull request Jun 13, 2024
SHA: 71242b6
Reason: push, by marcoscaceres

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants