Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow treeitems to omit groups by specifiying aria-level, aria-posinset, and aria-setsize #2091

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

smhigley
Copy link
Contributor

@smhigley smhigley commented Dec 14, 2023

Closes #2065

Make it clear that authors may create a tree with a flat DOM hierarchy of treeitem nodes inside a tree, as long as all treeitems have explicit values for aria-level, aria-setsize, and aria-posinset.

Open question: should we specify how aria-setsize and aria-posinset should be calculated?

PR tracking

Check these when the relevant issue or PR has been made, OR after you have confirmed the
related change is not necessary (add N/A). Leave unchecked if you are unsure. Read the
Process Document or
Test Overview for more information.

  • Related Core AAM Issue/PR: N/A
  • Related AccName Issue/PR: N/A
  • Related APG Issue/PR:
  • Any other dependent changes? N/A

Implementation tracking

  • "author MUST" tests:
  • "user agent MUST" tests:
  • Browser implementations (link to issue or when done, link to commit):
    • WebKit:
    • Gecko:
    • Blink:
  • Does this need AT implementations?

Preview | Diff

index.html Outdated Show resolved Hide resolved
@spectranaut
Copy link
Contributor

@mcking65 is this a change we would want to reflect in the APG?

@spectranaut
Copy link
Contributor

@smhigley should we discuss your question (should we specify how aria-setsize and aria-posinset should be calculated?) in a WG meeting?

Copy link
Contributor

@spectranaut spectranaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do think we need to be a bit more specific about how to calculate aria-level, if we think the only relevant "structure" is nested group elements.

index.html Outdated Show resolved Hide resolved
index.html Outdated
@@ -9997,6 +9997,12 @@ <h5>Presentational Role Inheritance</h5>
<li>The user interface makes the meaning and purpose of each state apparent.</li>
<li>The user interface provides a separate method for controlling each state.</li>
</ul>
<p>
User agents MUST calculate an implicit value for <sref>aria-level</sref> from the document structure if the author does not explicitly specify a value.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I guess this is related to your open question. Honestly, i think we might need to explicitly say how it is calculated, because "from the document structure" seems a little to vague to me.

For example, if the tree items are group with divs that don't have role group, I think we should ignore that structure, right? This sentence is not clear about that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spectranaut I actually already addressed my open question in this PR 😅: #2104

Which I think might also address your comment? Let me know if you think it needs different wording (though those comments probably belong on the other PR)

@smhigley
Copy link
Contributor Author

smhigley commented Feb 8, 2024

@spectranaut I think I've addressed your comments -- would you mind taking another look when you get a chance?

@pkra pkra added the spec:aria label Jun 14, 2024
@pkra pkra added the waiting for implementations Cannot be merged until there are two browser impls or one impl + impl commit label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec:aria waiting for implementations Cannot be merged until there are two browser impls or one impl + impl commit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hierarchy of treeitems per aria level only?
5 participants