-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow treeitems to omit groups by specifiying aria-level, aria-posinset, and aria-setsize #2091
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: Adam Page <[email protected]>
@mcking65 is this a change we would want to reflect in the APG? |
@smhigley should we discuss your question (should we specify how aria-setsize and aria-posinset should be calculated?) in a WG meeting? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do think we need to be a bit more specific about how to calculate aria-level, if we think the only relevant "structure" is nested group
elements.
index.html
Outdated
@@ -9997,6 +9997,12 @@ <h5>Presentational Role Inheritance</h5> | |||
<li>The user interface makes the meaning and purpose of each state apparent.</li> | |||
<li>The user interface provides a separate method for controlling each state.</li> | |||
</ul> | |||
<p> | |||
User agents MUST calculate an implicit value for <sref>aria-level</sref> from the document structure if the author does not explicitly specify a value. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I guess this is related to your open question. Honestly, i think we might need to explicitly say how it is calculated, because "from the document structure" seems a little to vague to me.
For example, if the tree items are group with divs that don't have role group, I think we should ignore that structure, right? This sentence is not clear about that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@spectranaut I actually already addressed my open question in this PR 😅: #2104
Which I think might also address your comment? Let me know if you think it needs different wording (though those comments probably belong on the other PR)
@spectranaut I think I've addressed your comments -- would you mind taking another look when you get a chance? |
Closes #2065
Make it clear that authors may create a tree with a flat DOM hierarchy of
treeitem
nodes inside atree
, as long as all treeitems have explicit values foraria-level
,aria-setsize
, andaria-posinset
.Open question: should we specify how
aria-setsize
andaria-posinset
should be calculated?PR tracking
Check these when the relevant issue or PR has been made, OR after you have confirmed the
related change is not necessary (add N/A). Leave unchecked if you are unsure. Read the
Process Document or
Test Overview for more information.
Implementation tracking
Preview | Diff