Update dialog definition #2054
Update dialog definition #2054
Conversation
|
I think we should have some discussion of the use cases and justification for aria-description on a dialog. I'm almost inclined to say that it should not be allowed. I think it deserves discussion though. |
|
I agree with Carolyn's questioning of the wording around "managing focus". Managing focus is relevant for composites and does not equate to constraining the tab ring. I'm happy to propose some alternative wording. @scottaohara How would you prefer I propose wording? It might be kind of difficult to do it with the suggestion feature? Are you OK with me pushing commits to this branch? Or, would you prefer I branch from this and use this branch as a base for a PR? |
|
@mcking65 yah, i think it does make sense to change the wording on 'managing focus'. happy for you to make commits to the branch. that'll be easy enough for me to review the diff. |
@mcking65 just trying to get this PR wrapped up, but I added a note about aria-description and made a wording changes to 'manage focus' (though that is existing text, and not added by this PR - so kinda out of scope, but i think an easy change worth making.
|
@mcking65 waiting for your review |
✅ Deploy Preview for wai-aria ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
SHA: d5e6cf3 Reason: push, by jnurthen Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Closes: #1195 adds content pertaining to aria-describedby/description and aria-modal (with linking to APG).
Closes: #1739 adds AT SHOULD to address the treatment of dialog descriptions. This could probably be worded better. Suggestions welcome.
Preview | Diff