Merge pull request #96 from matthewnessworthy/xlink

Include xmlns:xlink in <svg/> definition
w0rm · Dec 21, 2018 · 6187097 · 6187097
2 parents 391c9d3 + 67177ed
commit 6187097
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/index.js b/index.js
@@ -15,7 +15,7 @@ module.exports = function (config) {
   var inlineSvg = config.inlineSvg || false
   var ids = {}
 
-  var resultSvg = '<svg xmlns="http://www.w3.org/2000/svg"><defs/></svg>'
+  var resultSvg = '<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink"><defs/></svg>'
   if (!inlineSvg) {
     resultSvg =
       '<?xml version="1.0" encoding="UTF-8"?>' +

diff --git a/package.json b/package.json
@@ -37,7 +37,9 @@
     "sinon": "^1.16.1",
     "wd": "^0.4.0"
   },
-  "engines" : { "node" : ">=4.0" },
+  "engines": {
+    "node": ">=4.0"
+  },
   "engineStrict": true,
   "keywords": [
     "gulpplugin",

diff --git a/test.js b/test.js
@@ -120,7 +120,7 @@ describe('gulp-svgstore unit test', function () {
     stream.on('data', function (file) {
       var result = file.contents.toString()
       var target =
-      '<svg xmlns="http://www.w3.org/2000/svg">' +
+      '<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink">' +
       '<symbol id="circle" viewBox="0 0 4 4" preserveAspectRatio="xMinYMid meet"><circle cx="2" cy="2" r="1"/></symbol>' +
       '<symbol id="square"><rect x="1" y="1" width="2" height="2"/></symbol>' +
       '</svg>'
@@ -149,7 +149,7 @@ describe('gulp-svgstore unit test', function () {
     stream.on('data', function (file) {
       var result = file.contents.toString()
       var target =
-      '<svg xmlns="http://www.w3.org/2000/svg">' +
+      '<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink">' +
       '<symbol id="circle" viewBox="0 0 4 4"><circle cx="2" cy="2" r="1"/></symbol>' +
       '</svg>'
       assert.equal( result, target )
@@ -182,7 +182,7 @@ describe('gulp-svgstore unit test', function () {
     stream.on('data', function(file){
       var result = file.contents.toString()
       var target =
-        '<svg xmlns="http://www.w3.org/2000/svg">' +
+        '<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink">' +
         '<defs><circle id="circ" cx="2" cy="2" r="1"/></defs>' +
         '<symbol id="circle" viewBox="0 0 4 4"/>' +
         '</svg>'