Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #2421, rename Raw[Recording]CommandBufer again and move them #2582

Merged
merged 1 commit into from
Oct 19, 2024

Conversation

marc0246
Copy link
Contributor

This partially reverts #2421; see #2576 for rationale. Since the plan is that AutoCommandBufferBuilder and co. are eventually removed entirely, we're defensively renaming UnsafeCommandBuffer[Builder] again and removing the command_buffer::sys module such that we don't break these again.

Changelog:
Remove these lines:

### Breaking changes
Changes to command buffers:
- Renamed `AutoCommandBufferBuilder` to `RecordingCommandBuffer` and `AutoCommandBufferBuilder::build` to `end`.
- Renamed `UnsafeCommandBufferBuilder` to `RawRecordingCommandBuffer` and `UnsafeCommandBufferBuilder::build` to `end`.
- Renamed `UnsafeCommandBuffer` to `RawCommandBuffer`.
- `RecordingCommandBuffer` and `RawRecordingCommandBuffer` now take an `Arc<dyn CommandBufferAllocator>` on construction.
- `RecordingCommandBuffer`, `PrimaryAutoCommandBuffer`, `SecondaryAutoCommandBuffer`, `RawRecordingCommandBuffer` and `RawCommandBuffer` no longer have a type parameter for the type of allocator.
- `RawRecordingCommandBuffer::execute_commands` now takes `&RawCommandBuffer`s as argument.

Add these lines:

### Breaking changes
Changes to command buffers:
- Renamed `UnsafeCommandBufferBuilder` to `RecordingCommandBuffer` and `UnsafeCommandBufferBuilder::build` to `end`.
- Renamed `UnsafeCommandBuffer` to `CommandBuffer`.
- `RecordingCommandBuffer` and `CommandBuffer` were moved to the `command_buffer` module; the `command_buffer::sys` module was removed.
- `AutoCommandBufferBuilder`, `PrimaryAutoCommandBuffer`, `SecondaryAutoCommandBuffer`, `RecordingCommandBuffer` and `CommandBuffer` no longer have a type parameter for the type of allocator.
- `RecordingCommandBuffer::execute_commands` now takes `&CommandBuffer`s as argument.

@Rua Rua merged commit ba8aa2a into vulkano-rs:master Oct 19, 2024
6 checks passed
Rua added a commit that referenced this pull request Oct 19, 2024
@marc0246 marc0246 deleted the revert-2421 branch October 20, 2024 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants