Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix vkCmdDrawMeshIndirect() validation using wrong type #2581

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

Firestar99
Copy link
Contributor

  1. Update documentation to reflect any user-facing changes - in this repository.

  2. Make sure that the changes are covered by unit-tests.

  3. Run cargo clippy on the changes.

  4. Run cargo +nightly fmt on the changes.

  5. Please put changelog entries in the description of this Pull Request
    if knowledge of this change could be valuable to users. No need to put the
    entries to the changelog directly, they will be transferred to the changelog
    file by maintainers right after the Pull Request merge.

    Please remove any items from the template below that are not applicable.

  6. Describe in common words what is the purpose of this change, related
    GitHub Issues, and highlight important implementation aspects.

Changelog:

### Bugs fixed
- fixed `vkCmdDrawMeshIndirect` always returning a validation error 

@Rua
Copy link
Contributor

Rua commented Oct 18, 2024

Oops! Thanks for the fix!

@Rua Rua merged commit 552caad into vulkano-rs:master Oct 18, 2024
6 checks passed
@marc0246
Copy link
Contributor

Sidenote: ext_mesh_shader support isn't released yet. There's not going to be a changelog entry.

@Firestar99 Firestar99 deleted the draw_mesh_indirect branch October 18, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants