add null-check for empty arrays in debug trampoline #2490
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update documentation to reflect any user-facing changes - in this repository.
N/A
Make sure that the changes are covered by unit-tests.
Covered already in
debug
example binary.Run
cargo clippy
on the changes.None new, some exist already upstream.
Run
cargo +nightly fmt
on the changes.Please put changelog entries in the description of this Pull Request
if knowledge of this change could be valuable to users. No need to put the
entries to the changelog directly, they will be transferred to the changelog
file by maintainers right after the Pull Request merge.
Please remove any items from the template below that are not applicable.
Describe in common words what is the purpose of this change, related
Github Issues, and highlight important implementation aspects.
A simple check for null pointers in the debug callback. My current device (
Mesa 24.0.2-arch1.1
on deviceIntel(R) HD Graphics 2500 (IVB GT1)
) reports a null pointer with count of zero for empty arrays - this is allowable under the vulkan spec forVkDebugUtilsMessengerCallbackDataEXT
but is invalid for use inslice::from_raw_parts
which needs a well-aligned non-null pointer part even for zero length slices.Changelog:
### Bugs fixed Fix UB in debug messenger when driver reports null pointers for empty arrays.