Minor reorganization of shader validation code #2445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marc0246
reviewed
Jan 5, 2024
hakolao
pushed a commit
to hakolao/vulkano
that referenced
this pull request
Feb 20, 2024
* Minor reorganization of shader validation code * Track call tree of SPIR-V functions * Restore fixme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've split the
pipeline::shadermodule into two submodules, with the idea that additional submodules will follow. I also created a new reusableinput_output_mapthat handles the common code inget_variables_by_keyandshader_interface_location_info, and will also be used for future shader validation code that I'm working on.