Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: text() misses content for array functional component #2579

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

miguelrincon
Copy link

Fix for #2568

This change adds a new optional parameter to the DOMWrapper constructor so information about its structure can be later used to produce correct text() and html() assertions.

@miguelrincon miguelrincon marked this pull request as draft December 31, 2024 14:32
Copy link

netlify bot commented Dec 31, 2024

Deploy Preview for vue-test-utils-docs ready!

Name Link
🔨 Latest commit d2b4fbc
🔍 Latest deploy log https://app.netlify.com/sites/vue-test-utils-docs/deploys/677401e17a685900086e0419
😎 Deploy Preview https://deploy-preview-2579--vue-test-utils-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@miguelrincon
Copy link
Author

@cexbrayat This is an initial idea to fix #2568, all tests are passing but I hacked a bit around the types and method signatures. I'll need help to get those fixed ;)

I am also not sure if changing the DOMWrapper constructor to take a vnode it's a better fit, as the vnode contains more information we may need (rather than just the new subtree param), seems like a bigger change than I'd like to take on.

cc @xanf

@miguelrincon miguelrincon force-pushed the 2568-fix-func-component-array branch from b03d208 to d2b4fbc Compare December 31, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant