Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: respect preferred-reduce-motion #744

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

alexzhang1030
Copy link
Member

cloese #547.

Now we only align with preferred-reduce-motion to solve the consistency.

Copy link

netlify bot commented Dec 16, 2024

Deploy Preview for vue-devtools-docs canceled.

Name Link
🔨 Latest commit 0c4542b
🔍 Latest deploy log https://app.netlify.com/sites/vue-devtools-docs/deploys/675fa5b53ea53a0008b33877

Copy link

pkg-pr-new bot commented Dec 16, 2024

Open in Stackblitz

@vue/devtools-applet

npm i https://pkg.pr.new/@vue/devtools-applet@744

@vue/devtools-core

npm i https://pkg.pr.new/@vue/devtools-core@744

@vue/devtools

npm i https://pkg.pr.new/@vue/devtools@744

@vue/devtools-api

npm i https://pkg.pr.new/@vue/devtools-api@744

@vue/devtools-kit

npm i https://pkg.pr.new/@vue/devtools-kit@744

vite-plugin-vue-devtools

npm i https://pkg.pr.new/vite-plugin-vue-devtools@744

commit: 0c4542b

@webfansplz
Copy link
Member

Would it be better if we provided a toggle button in the Settings page?

@alexzhang1030
Copy link
Member Author

Would it be better if we provided a toggle button in the Settings page?

Kinda complicated.

We have two states to determine the final reduce motion. It's not too hard to implement, but the behavior is counter-perception.

Let's describe a scenario:

  • System reduce motion is off
  • User manually set "reduce motion" of devtools is true
  • Now devtools reduce motion is true now
  • System reduce motion is on
  • Devtools reduce motion is true, of course.
  • System reduce motion is off
  • Should we disable devtools reduce motion?
    • We can do nothing because enabling/disabling all brings new issues.

@webfansplz webfansplz changed the title feat: align with preferred-reduce-motion feat: respect preferred-reduce-motion Dec 23, 2024
@webfansplz webfansplz merged commit e5e585e into vuejs:main Dec 23, 2024
7 checks passed
@alexzhang1030 alexzhang1030 deleted the feat/reduce-motion branch December 24, 2024 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants