Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime-core): prevent redundant updates to currentInstance #12632

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

edison1105
Copy link
Member

close #12631

Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB (+19 B) 37.9 kB (+9 B) 34.2 kB (-10 B)
vue.global.prod.js 158 kB (+19 B) 57.8 kB (+9 B) 51.5 kB (+95 B)

Usages

Name Size Gzip Brotli
createApp (CAPI only) 46.3 kB (+19 B) 18.2 kB (+11 B) 16.6 kB (+14 B)
createApp 54.3 kB (+19 B) 21.1 kB (+8 B) 19.3 kB (+10 B)
createSSRApp 58.4 kB (+19 B) 22.9 kB (+12 B) 20.8 kB (+11 B)
defineCustomElement 59.1 kB (+19 B) 22.7 kB (+9 B) 20.7 kB (+10 B)
overall 68.3 kB (+19 B) 26.3 kB (+10 B) 23.9 kB (+22 B)

Copy link

pkg-pr-new bot commented Dec 31, 2024

Open in Stackblitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@12632

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@12632

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@12632

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@12632

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@12632

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@12632

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@12632

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@12632

@vue/shared

npm i https://pkg.pr.new/@vue/shared@12632

vue

npm i https://pkg.pr.new/vue@12632

@vue/compat

npm i https://pkg.pr.new/@vue/compat@12632

commit: acb325c

@edison1105 edison1105 added ready to merge The PR is ready to be merged. 🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. labels Dec 31, 2024
@edison1105 edison1105 changed the title fix(runtime-core): prevent updating instance if it's already the current instance fix(runtime-core): prevent updating currentInstance if it's already the current instance Dec 31, 2024
@edison1105 edison1105 changed the title fix(runtime-core): prevent updating currentInstance if it's already the current instance fix(runtime-core): prevent redundant updates to currentInstance Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. ready to merge The PR is ready to be merged.
Projects
None yet
1 participant