[HOLD] workflow: move private packages to separate directory #11520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yyx990803
changed the title
Size ReportBundles
Usages
|
sxzz
reviewed
Aug 8, 2024
| @@ -30,12 +30,13 @@ | |||
| "include": [ | |||
| "packages/global.d.ts", | |||
| "packages/*/src", | |||
| "packages-private/*/src", | |||
There was a problem hiding this comment.
It’s a good idea to create a separate tsconfig for packages-private instead of using the one in the root directory. This way, we’ll have more control over setting the target to esnext.
yyx990803
force-pushed
the
separate-private-packages
branch
from
ed8754c to
da49894
Compare
❌ Deploy Preview for vue-sfc-playground failed.
|
❌ Deploy Preview for vue-next-template-explorer failed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also addes a
vite-debugpackage for debugging Vite plugin specific issues.This changes the root directory of both
sfc-playgroundandtemplate-explorer. Since vercel / netlify cannot conditionally specify root dir based on branch, we will have to wait until we moveminortomainafter 3.5 release before merging this.