Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: translate developer articles #1055

Merged
merged 3 commits into from
Jan 18, 2025

Conversation

lxKylin
Copy link
Contributor

@lxKylin lxKylin commented Dec 31, 2024

在创建 pull request 之前

请确认:

  • 我已经阅读过项目的 wiki 了解相关注意事项。
  • 我对翻译内容的改动不包含基于英文原版的扩展、删减或演绎 (如有,请移步至英文文档仓库讨论,相关结论会被定期从英文版同步)

问题描述

image

Copy link

vercel bot commented Dec 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-zh-cn ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2025 0:21am

@@ -57,13 +59,16 @@ const partnerConfig = {
// Diagram sections
profileDiagram: {
title: 'Candidate profile',
prependText: 'How our developers score in the parameters that correlate best with future success in the role.'
prependText:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以维持原先的段落格式,避免后续改动无法跟踪,下同

title: 'Become a listed developer',
description: 'Get a long-term part-time or full-time position at company looking for a Vue.js developer.',
title: '成为一名注册开发者',
description:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

维持原格式,不换行~


const websiteLabel = 'proxify.io'
const websiteUrl = 'https://proxify.io/'
const applyUrl = 'https://career.proxify.io/apply'
const hireUrl = 'https://proxify.io/hire-vuejs'
const vueArticleUrl = 'https://proxify.io/hire-vue-developers'
const imageStorageUrl = 'https://res.cloudinary.com/proxify-io/image/upload'
const imageStorageUrl =
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不换行

@@ -44,7 +44,7 @@ onMounted(() => {
target="_blank"
class="accent-button"
>
Contact {{ partnerConfig.partnerName }} for a tailored fit
联系 Proxify 获取定制化的服务
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

维持原先的对象引用,去改上游的 partnerConfig.partnerName 的翻译,这样就可以维持原结构了。

Copy link
Member

@veaba veaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

辛苦再调整下,后面可以合进来了。

src/developers/partnerConfig.js Outdated Show resolved Hide resolved
@@ -1,7 +1,7 @@
import partnerData from '../partners/partners.json'

const partnerName = 'Proxify'
const partner = partnerData.find(partner => partner.name === partnerName)
const partner = partnerData.find((partner) => partner.name === partnerName)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const partner = partnerData.find((partner) => partner.name === partnerName)
const partner = partnerData.find(partner => partner.name === partnerName)

可以维持原先格式。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

幸苦了

@veaba veaba merged commit ad3ac25 into vuejs-translations:main Jan 18, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants