feat: adjust rating styles #2635
Merged
+45
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
artursantiago
changed the title
This was referenced Jan 28, 2025
Merged
Merged
artursantiago
changed the title
artursantiago
requested review from
hellofanny and
pedromtec
and removed request for
a team
hellofanny
reviewed
Feb 3, 2025
hellofanny
reviewed
Feb 4, 2025
artursantiago
force-pushed
the
feat/adjust-actionable-rating
branch
from
4632fa9 to
7470db2
Compare
hellofanny
reviewed
Feb 5, 2025
hellofanny
approved these changes
Feb 6, 2025
|
@mariana-caetano JTLYK We are updating this component tokens. I've open a request here |
2 tasks
hellofanny
added a commit
that referenced
this pull request
Feb 13, 2025
>⚠️ THIS PR DEPENDS ON [PR#2635](#2635)⚠️ ## What's the purpose of this pull request? This pull request adds the RatingField component, which will initially be used in the modal for adding reviews to a product. ## How it works? This PR creates a new molecule component called `RatingField`. In addition to the "input" fields for the actionable rating, it can also receive an `id`, `label`, and `error` via props to be displayed in the form. The component uses the `Rating` component with the `actionable` view, passing the `onChange` handler to it. ## How to test it? <!--- Describe the steps with bullet points. Is there any external link that can be used to better test it or an example? ---> ### Starters Deploy Preview <!--- Add a link to a deploy preview from `starter.store` with this branch being used. ---> <!--- Tip: You can get an installable version of this branch from the CodeSandbox generated when this PR is created. ---> [Preview](https://starter-git-feat-rating-field-vtex.vercel.app//review-and-ratings-playground) ## References [JIRA TASK: SFS-2078](https://vtex-dev.atlassian.net/browse/SFS-2078) [JIRA TASK: SFS-2077](https://vtex-dev.atlassian.net/browse/SFS-2077) [Figma](https://www.figma.com/design/YXU6IX2htN2yg7udpCumZv/Reviews-%26-Ratings?node-id=131-49445&t=iOanfcOwmDa4bolf-4)   --------- Co-authored-by: Fanny Chien <fanny.chien@vtex.com> Co-authored-by: Fanny Chien <fannychienn@gmail.com>
artursantiago
added a commit
that referenced
this pull request
Feb 14, 2025
## What's the purpose of this pull request? This pull request introduces adjustments to the **Rating component** for the new **Reviews & Ratings** section. ## How it works? It updates the colors for both the default and actionable versions, using `main-2` for active stars and `neutral-4` for empty stars. Additionally, it includes the addition of a `disabled` style for the actionable rating. ## How to test it? <!--- Describe the steps with bullet points. Is there any external link that can be used to better test it or an example? ---> ### Starters Deploy Preview <!--- Add a link to a deploy preview from `starter.store` with this branch being used. ---> <!--- Tip: You can get an installable version of this branch from the CodeSandbox generated when this PR is created. ---> [Preview](https://starter-git-feat-rating-field-vtex.vercel.app/review-and-ratings-playground) ## References [JIRA TASK: SFS-2077](https://vtex-dev.atlassian.net/browse/SFS-2077) [Figma](https://www.figma.com/design/YXU6IX2htN2yg7udpCumZv/Reviews-%26-Ratings?node-id=131-49445&t=97j1KIeA0brteiq8-4) Default  Actionable 
artursantiago
added a commit
that referenced
this pull request
Feb 14, 2025
>⚠️ THIS PR DEPENDS ON [PR#2635](#2635)⚠️ ## What's the purpose of this pull request? This pull request adds the RatingField component, which will initially be used in the modal for adding reviews to a product. ## How it works? This PR creates a new molecule component called `RatingField`. In addition to the "input" fields for the actionable rating, it can also receive an `id`, `label`, and `error` via props to be displayed in the form. The component uses the `Rating` component with the `actionable` view, passing the `onChange` handler to it. ## How to test it? <!--- Describe the steps with bullet points. Is there any external link that can be used to better test it or an example? ---> ### Starters Deploy Preview <!--- Add a link to a deploy preview from `starter.store` with this branch being used. ---> <!--- Tip: You can get an installable version of this branch from the CodeSandbox generated when this PR is created. ---> [Preview](https://starter-git-feat-rating-field-vtex.vercel.app//review-and-ratings-playground) ## References [JIRA TASK: SFS-2078](https://vtex-dev.atlassian.net/browse/SFS-2078) [JIRA TASK: SFS-2077](https://vtex-dev.atlassian.net/browse/SFS-2077) [Figma](https://www.figma.com/design/YXU6IX2htN2yg7udpCumZv/Reviews-%26-Ratings?node-id=131-49445&t=iOanfcOwmDa4bolf-4)   --------- Co-authored-by: Fanny Chien <fanny.chien@vtex.com> Co-authored-by: Fanny Chien <fannychienn@gmail.com>
artursantiago
added a commit
that referenced
this pull request
Feb 14, 2025
## What's the purpose of this pull request? This pull request introduces adjustments to the **Rating component** for the new **Reviews & Ratings** section. ## How it works? It updates the colors for both the default and actionable versions, using `main-2` for active stars and `neutral-4` for empty stars. Additionally, it includes the addition of a `disabled` style for the actionable rating. ## How to test it? <!--- Describe the steps with bullet points. Is there any external link that can be used to better test it or an example? ---> ### Starters Deploy Preview <!--- Add a link to a deploy preview from `starter.store` with this branch being used. ---> <!--- Tip: You can get an installable version of this branch from the CodeSandbox generated when this PR is created. ---> [Preview](https://starter-git-feat-rating-field-vtex.vercel.app/review-and-ratings-playground) ## References [JIRA TASK: SFS-2077](https://vtex-dev.atlassian.net/browse/SFS-2077) [Figma](https://www.figma.com/design/YXU6IX2htN2yg7udpCumZv/Reviews-%26-Ratings?node-id=131-49445&t=97j1KIeA0brteiq8-4) Default  Actionable 
artursantiago
added a commit
that referenced
this pull request
Feb 14, 2025
>⚠️ THIS PR DEPENDS ON [PR#2635](#2635)⚠️ ## What's the purpose of this pull request? This pull request adds the RatingField component, which will initially be used in the modal for adding reviews to a product. ## How it works? This PR creates a new molecule component called `RatingField`. In addition to the "input" fields for the actionable rating, it can also receive an `id`, `label`, and `error` via props to be displayed in the form. The component uses the `Rating` component with the `actionable` view, passing the `onChange` handler to it. ## How to test it? <!--- Describe the steps with bullet points. Is there any external link that can be used to better test it or an example? ---> ### Starters Deploy Preview <!--- Add a link to a deploy preview from `starter.store` with this branch being used. ---> <!--- Tip: You can get an installable version of this branch from the CodeSandbox generated when this PR is created. ---> [Preview](https://starter-git-feat-rating-field-vtex.vercel.app//review-and-ratings-playground) ## References [JIRA TASK: SFS-2078](https://vtex-dev.atlassian.net/browse/SFS-2078) [JIRA TASK: SFS-2077](https://vtex-dev.atlassian.net/browse/SFS-2077) [Figma](https://www.figma.com/design/YXU6IX2htN2yg7udpCumZv/Reviews-%26-Ratings?node-id=131-49445&t=iOanfcOwmDa4bolf-4)   --------- Co-authored-by: Fanny Chien <fanny.chien@vtex.com> Co-authored-by: Fanny Chien <fannychienn@gmail.com>
artursantiago
added a commit
that referenced
this pull request
Feb 14, 2025
## What's the purpose of this pull request? This pull request introduces adjustments to the **Rating component** for the new **Reviews & Ratings** section. ## How it works? It updates the colors for both the default and actionable versions, using `main-2` for active stars and `neutral-4` for empty stars. Additionally, it includes the addition of a `disabled` style for the actionable rating. ## How to test it? <!--- Describe the steps with bullet points. Is there any external link that can be used to better test it or an example? ---> ### Starters Deploy Preview <!--- Add a link to a deploy preview from `starter.store` with this branch being used. ---> <!--- Tip: You can get an installable version of this branch from the CodeSandbox generated when this PR is created. ---> [Preview](https://starter-git-feat-rating-field-vtex.vercel.app/review-and-ratings-playground) ## References [JIRA TASK: SFS-2077](https://vtex-dev.atlassian.net/browse/SFS-2077) [Figma](https://www.figma.com/design/YXU6IX2htN2yg7udpCumZv/Reviews-%26-Ratings?node-id=131-49445&t=97j1KIeA0brteiq8-4) Default  Actionable 
artursantiago
added a commit
that referenced
this pull request
Feb 14, 2025
>⚠️ THIS PR DEPENDS ON [PR#2635](#2635)⚠️ ## What's the purpose of this pull request? This pull request adds the RatingField component, which will initially be used in the modal for adding reviews to a product. ## How it works? This PR creates a new molecule component called `RatingField`. In addition to the "input" fields for the actionable rating, it can also receive an `id`, `label`, and `error` via props to be displayed in the form. The component uses the `Rating` component with the `actionable` view, passing the `onChange` handler to it. ## How to test it? <!--- Describe the steps with bullet points. Is there any external link that can be used to better test it or an example? ---> ### Starters Deploy Preview <!--- Add a link to a deploy preview from `starter.store` with this branch being used. ---> <!--- Tip: You can get an installable version of this branch from the CodeSandbox generated when this PR is created. ---> [Preview](https://starter-git-feat-rating-field-vtex.vercel.app//review-and-ratings-playground) ## References [JIRA TASK: SFS-2078](https://vtex-dev.atlassian.net/browse/SFS-2078) [JIRA TASK: SFS-2077](https://vtex-dev.atlassian.net/browse/SFS-2077) [Figma](https://www.figma.com/design/YXU6IX2htN2yg7udpCumZv/Reviews-%26-Ratings?node-id=131-49445&t=iOanfcOwmDa4bolf-4)   --------- Co-authored-by: Fanny Chien <fanny.chien@vtex.com> Co-authored-by: Fanny Chien <fannychienn@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
This pull request introduces adjustments to the Rating component for the new Reviews & Ratings section.
How it works?
It updates the colors for both the default and actionable versions, using
main-2for active stars andneutral-4for empty stars.Additionally, it includes the addition of a
disabledstyle for the actionable rating.How to test it?
Starters Deploy Preview
Preview
References
JIRA TASK: SFS-2077
Figma
Default
Actionable