-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/product comparison api #2627
Open
HiagoMoreiraCubos
wants to merge
19
commits into
vtex:main
Choose a base branch
from
cubos-vtex:feat/product-comparison-api
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feat/product comparison api #2627
HiagoMoreiraCubos
wants to merge
19
commits into
vtex:main
from
cubos-vtex:feat/product-comparison-api
+698
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e283c08.
…uct-comparison-api
HiagoMoreiraCubos
added
enhancement
New feature or request
contributing
Pull request submitted by the community
labels
Jan 24, 2025
HiagoMoreiraCubos
requested review from
hellofanny and
emersonlaurentino
and removed request for
a team
January 24, 2025 19:55
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
This PR creates a new form of request for product search without affecting existing searches. Thus creating the
useProductsSelected
hook.How it works?
When using
useProductSelected
it is necessary to pass an array of pre-selected product IDs, obtaining the return of all selected product data. The hook works because a new products attribute was created within query.ts. In addition to having added 3 more properties to aid in the development of the ProductComparison component (hasSpecifications
,skuSpecifications
,specificationGroups
).