-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: adds nofollow from config #675
Open
eduardoformiga
wants to merge
5
commits into
main
Choose a base branch
from
feat/adds-noindex-from-config-SFS-2141
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
eduardoformiga
added a commit
to vtex/faststore
that referenced
this pull request
Jan 31, 2025
## What's the purpose of this pull request? This PR aims to enable the `nofollow` prop from NextSeo from the discovery.config value. ## How it works? The default value is true as was previously, but the stores can switch to false as needed. ## How to test it? You can switch the value from `discovery.config.js `-> `seo.search.noFollow` and check the value from the meta tag related. ### Starters Deploy Preview - vtex-sites/starter.store#675 | [nofollow true](https://storeframework-cm652ufll028lmgv665a6xv0g-dgphn5fzx.b.vtex.app/s?q=headphone&fuzzy=0&operator=and&facets=fuzzy%2Coperator&sort=score_desc&page=0) | [nofollow false](https://storeframework-cm652ufll028lmgv665a6xv0g-7mt68ho4g.b.vtex.app/s?q=headphone&fuzzy=0&operator=and&facets=fuzzy%2Coperator&sort=score_desc&page=0) | |--------|--------| | <img width="1274" alt="Screenshot 2025-01-30 at 12 08 55" src="https://github.com/user-attachments/assets/0e2a542c-cc97-47c5-a4e1-b8110d47076f" /> | <img width="1297" alt="Screenshot 2025-01-30 at 12 05 31" src="https://github.com/user-attachments/assets/498411b9-86ef-4da4-9e8d-47dfe89f653d" /> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
noFollow
from config vtex/faststore#2656How does it work?
How to test it?
Faststore related PRs
References