Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use return instead of throwing a duplicate email error. #166

Merged

Conversation

Rudge
Copy link
Contributor

@Rudge Rudge commented Oct 7, 2024

What problem is this solving?

We found a lot of error logs when the user already exists and someone tries to add the same email.
So, we removed the throwing to avoid excessive logs of errors treated.

How should this be manually tested?

Try to add an existing email user to the Buyer organization.

Screenshots or example usage:
image

Copy link

vtex-io-ci-cd bot commented Oct 7, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Oct 7, 2024

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

@Rudge Rudge force-pushed the hotfix/B2BTEAM-1906-change-throw-to-return-duplicated-email branch from 1a397db to 459e5a1 Compare October 7, 2024 17:16
Copy link

github-actions bot commented Oct 7, 2024

Messages
📖 ❤️ Thanks!
📖

🎉 PR additions = 8, PR deletions = 3

Generated by 🚫 dangerJS against 459e5a1

@Rudge Rudge requested a review from a team October 7, 2024 17:17
Copy link

sonarqubecloud bot commented Oct 7, 2024

@Rudge Rudge merged commit e434ef4 into master Oct 7, 2024
14 checks passed
@Rudge Rudge deleted the hotfix/B2BTEAM-1906-change-throw-to-return-duplicated-email branch October 7, 2024 20:19
Copy link

vtex-io-ci-cd bot commented Oct 7, 2024

Your PR has been merged! App is being published. 🚀
Version 1.44.9 → 1.44.10

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants