Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FSEUS-521] Error changing Cost Center after placing order #165

Merged
merged 6 commits into from
Oct 10, 2024

Conversation

wender
Copy link
Collaborator

@wender wender commented Oct 2, 2024

What problem is this solving?

Fixed

When the user changes organization right after placing an order, the session is not updated.
The PR consists of adding additional session control, forcing the session watcher to update the namespace values.
Also implemented a reusable retry functionality to updateSession

How should this be manually tested?

  • Log in with a user that has more than one Organization/Cost Center
  • Place an order
  • Still, on the Order Placed page, change the Organization/Cost Center
  • If there is an error, it won't update the selection (visible in the top bar)

Copy link

vtex-io-ci-cd bot commented Oct 2, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@wender wender requested a review from enzomerca October 2, 2024 22:13
Copy link

github-actions bot commented Oct 2, 2024

Messages
📖 ❤️ Thanks!
📖

🎉 PR additions = 70, PR deletions = 11

Generated by 🚫 dangerJS against 5f6e517

node/resolvers/Mutations/Users.ts Outdated Show resolved Hide resolved
node/resolvers/Mutations/Users.ts Outdated Show resolved Hide resolved
node/resolvers/Mutations/Users.ts Outdated Show resolved Hide resolved
node/resolvers/Mutations/Users.ts Show resolved Hide resolved
node/resolvers/Mutations/Users.ts Outdated Show resolved Hide resolved
@wender wender requested a review from enzomerca October 3, 2024 14:46
Copy link

@enzomerca enzomerca merged commit 124d26b into master Oct 10, 2024
12 checks passed
@enzomerca enzomerca deleted the bugfix/changing-costcenter-after-order-placed branch October 10, 2024 12:16
Copy link

vtex-io-ci-cd bot commented Oct 10, 2024

Your PR has been merged! App is being published. 🚀
Version 1.44.10 → 1.44.11

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants