Adjust session provider early return logic #164
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this solving?
Adjusts the logic of the previous PR so as not to break VTEX "legacy" call center operator impersonation functionality.
In the B2B impersonation scenario, the session provider must validate that the user has a
storeUserEmail
in their session -- in other words, they must be logged in to the storefront to be able to impersonate another B2B user.In the legacy impersonation scenario, the user must be accessing
account.myvtex.com
as an admin user with the call center operator role, but not necessarily logged into the storefront. ThestoreUserEmail
should not be validated in this case.How should this be manually tested?
New version linked and tested in https://arthur--helmethouseprod.myvtex.com