Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust b2b-organizations-graphql integration #128

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

Rudge
Copy link
Contributor

@Rudge Rudge commented Feb 21, 2024

What problem is this solving?

  • We have an integration between storefront-permissions and b2b-organizations, and it is necessary to validate authentication in the request. But for some reason the storefront-permissions can't forward the cookie headers, and the token doesn't come in b2b-organization-graphql.

So, we change the integration structure and the graphql server intermediation to use the header x-vtex-caller as vtex.storefront-permissions and allow in b2b-organizations.

How should this be manually tested?

  • Login in the b2b store.

Screenshots or example usage:

@Rudge Rudge requested a review from a team February 21, 2024 18:22
Copy link

vtex-io-ci-cd bot commented Feb 21, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

Copy link

github-actions bot commented Feb 21, 2024

Messages
📖 ❤️ Thanks!
📖

🎉 PR additions = 15, PR deletions = 16

Generated by 🚫 dangerJS against 9157472

Copy link

@Rudge Rudge merged commit a2bfd36 into master Feb 27, 2024
13 checks passed
@Rudge Rudge deleted the hotfix/B2BTEAM-1538-change-organization-integration branch February 27, 2024 15:00
Copy link

vtex-io-ci-cd bot commented Feb 27, 2024

Your PR has been merged! App is being published. 🚀
Version 1.39.2 → 1.39.3

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants