Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add isDisposable prop #124

Merged
merged 2 commits into from
Dec 7, 2023

Conversation

ArthurTriis1
Copy link
Contributor

@ArthurTriis1 ArthurTriis1 commented Dec 7, 2023

What problem is this solving?

This pull request introduces the 'isDisposable' property to create address requests, indicating whether the address is disposable to prevent duplicates.

More informations can be seen on this thread

B2BTEAM-1511

Copy link

vtex-io-ci-cd bot commented Dec 7, 2023

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

Copy link

github-actions bot commented Dec 7, 2023

Messages
📖 ❤️ Thanks!
📖

🎉 PR additions = 5, PR deletions = 0

Generated by 🚫 dangerJS against 913743d

@ArthurTriis1 ArthurTriis1 requested a review from wender December 7, 2023 14:50
Copy link

sonarqubecloud bot commented Dec 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

warning The version of Java (11.0.17) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@ArthurTriis1 ArthurTriis1 merged commit d8948cb into master Dec 7, 2023
13 checks passed
@ArthurTriis1 ArthurTriis1 deleted the fix/add-isDisposable-prop-in-address branch December 7, 2023 17:10
Copy link

vtex-io-ci-cd bot commented Dec 7, 2023

Your PR has been merged! App is being published. 🚀
Version 1.37.2 → 1.37.3

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants