-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add directive to validate auth token #123
Conversation
- adjust validation log to map the operation jira: B2BTEAM-1287
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
Beep boop 🤖 I noticed you didn't make any changes at the
In order to keep track, I'll create an issue if you decide now is not a good time
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code lgtm, but just to be sure: did the metrics from the existing @auditAccess
directive already show that we can turn on this token validation without breaking existing stores? Just worried that this might cause problems for callers that are using it wrong, specially since we're near BF.
Also, there's a check failing right now. It's just about selecting a checkbox on the doc question post from the bot though. |
- remove token from field and operation from message
df08689
to
b0ee130
Compare
462f71a
to
883a8d7
Compare
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Your PR has been merged! App is being published. 🚀 After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:
After that your app will be updated on all accounts. For more information on the deployment process check the docs. 📖 |
What problem is this solving?
Some operations that return sensitive information don't validate the admin or store token. So I added the directive
@checkUserAccess
to validate the token before calling the operation.I improved the log warning for token validation by logging the operation that has an invalid token.
The operations were previously mapped in the task, and with the directive that was added
@auditAcess
.How should this be manually tested?
Workspace