-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Twitter meta tags to product page #530
base: master
Are you sure you want to change the base?
Conversation
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
Beep boop 🤖 I noticed you didn't make any changes at the
In order to keep track, I'll create an issue if you decide now is not a good time
|
…ayed when enabled
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you update the CHANGELOG file?
Also, please take a look into why the tests are failing. It's probably because there's no mock definition for vtex.twitter-meta-tags
:)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @edyespinal for the contribution 👏 !
Left some comments take a look at it.
Remove unnecessary blank line. Co-authored-by: Igor Brasileiro <[email protected]>
"description": "admin/store.twitterUsername.description", | ||
"type": "string" | ||
}, | ||
"twitterCard": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @victorhmp
I was doing a little digging to see what is causing the issue of the title and description not being displayed and the dropdown not having the correct style.
I noticed that we are using react-jsonschema-form to construct the store settings (for the apps' settings as well).
After reading the documentation, I don't see what we are doing wrong here. Maybe it's something when the VTEX Styleguide is being applied to the components.
After testing the same settings inside an apps settings form, this is what we get:
Screen.Recording.2021-09-16.at.14.49.45.mov
When testing the settings directly with react-jsonschema-form, this is what we get:
Screen.Recording.2021-09-16.at.14.44.18.mov
As you can see, in both cases the title and the description is displayed and the dropbox is styled correctly.
What should we do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@edyespinal this is awesome! Great investigation!
I have an idea! Could you try importing the Dropdown
component from react/components/form/Dropdown
and adding it to the widgets
object created here? This might just do it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @victorhmp
I tried your approach but we are still getting the same results.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi team!
Is there anything else we need to do about this app?
Co-authored-by: Victor Hugo Miranda Pinto <[email protected]>
…l/store into feat/twitter-meta-tags
I think we need to solve this problem where the label of the field is not being shown before releasing the feature. |
Hi @davicostalf 👋🏼
Is there a workaround we can implement for this while the issue is fixed?
Yes, we took your comment into consideration and made the change. You can see it here. Also, the message was changed by removing the |
Hey team! |
What problem is this solving?
This PR adds the possibility to add Twitter meta tags to a store's Product Page. The tags can be included by toggling the option in
Admin > CMS > Store
The meta tags that are being added are the following:
The settings added to the store's settingsSchema for this app can be found here and the logic to add the
meta tags
can be found here.How to test it?
The Twitter Meta Tags and the Store apps are linked in this workspace.
To test it, make sure the
includeTwitterMetaTags
toggle is checked and add the Twitter Username and Twitter Card text fields are filled. Then visit any product page and look check for the Meta Tags that are being added.Screenshots or example usage: