Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return an empty array to the deprecated checkout endpoint #668

Merged
merged 8 commits into from
Sep 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.

## [Unreleased]

### Deprecated
- Checkout orders endpoint now returns an empty array

## [2.171.1] - 2024-09-03

### Fixed
Expand Down
9 changes: 8 additions & 1 deletion node/clients/checkout.ts
Original file line number Diff line number Diff line change
Expand Up @@ -220,8 +220,15 @@ export class Checkout extends JanusClient {
})
}

// Deprecated: This endpoint is deprecated and any request will return an empty array
public orders = () =>
this.get(this.routes.orders, { metric: 'checkout-orders' })
this.get(this.routes.orders, { metric: 'checkout-orders' }).catch((err) => {
if (err.response && err.response.status === 405) {
return []
}

throw err
})

public simulation = (simulation: SimulationPayload) =>
this.post<SimulationOrderForm>(
Expand Down
Loading